Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker build files and instructions #13

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

avioletheart
Copy link
Contributor

No description provided.

@Oliveriver
Copy link
Owner

I'm unfortunately hitting an error trying to run this. The database and front end start ok but the back end fails to start with the following error:

exec /app/docker-entrypoint.sh: no such file or directory

@Oliveriver
Copy link
Owner

Ok, fixed the issue by changing docker-entrypoint.sh to use LF instead of CRLF. But considering this appears to be broken for anyone who has the Windows line ends setting in Git (which may be many people), I can't merge this in its current state.

Can the contents of that file be put in Dockerfile to avoid this conflict altogether?

@avioletheart
Copy link
Contributor Author

@Oliveriver i added .gitattributes which should fix the issue, can you check if that's the case? i don't have a windows machine to test on

Copy link
Owner

@Oliveriver Oliveriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with this change is that it changes most people's installation mechanism to use a system that I, the primary maintainer of the project, don't understand. I think it's great that it's possible to do and see no reason not to merge changes that enable it, but marking it as the recommended installation path is concerning to me.

server/appsettings.json Outdated Show resolved Hide resolved
server/docker-entrypoint.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Oliveriver
Copy link
Owner

One other thing I almost forgot to mention: it takes some time after start-up for the database migrations to run and as far as the average user is concerned, they run silently. So ideally there should be an indication that the process is ongoing, or at least there should be an instruction to wait in the readme.

@Oliveriver Oliveriver merged commit 1fc2338 into Oliveriver:main Sep 20, 2024
2 checks passed
@avioletheart avioletheart deleted the docker branch September 20, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants