-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker build files and instructions #13
Conversation
I'm unfortunately hitting an error trying to run this. The database and front end start ok but the back end fails to start with the following error:
|
Ok, fixed the issue by changing Can the contents of that file be put in |
@Oliveriver i added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern with this change is that it changes most people's installation mechanism to use a system that I, the primary maintainer of the project, don't understand. I think it's great that it's possible to do and see no reason not to merge changes that enable it, but marking it as the recommended installation path is concerning to me.
One other thing I almost forgot to mention: it takes some time after start-up for the database migrations to run and as far as the average user is concerned, they run silently. So ideally there should be an indication that the process is ongoing, or at least there should be an instruction to wait in the readme. |
900995a
to
9742e7d
Compare
No description provided.