improve setAta error handling

OlivierZal · Oct 1, 2024 · cdd18b6 · cdd18b6
1 parent cc669d3
commit cdd18b6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@olivierzal/melcloud-api",
-  "version": "11.0.1",
+  "version": "11.0.2",
   "description": "MELCloud API for Node.js",
   "keywords": [
     "melcloud",

diff --git a/src/decorators/updateDevices.ts b/src/decorators/updateDevices.ts
@@ -21,6 +21,9 @@ export default <T extends boolean | FailureData | GroupAtaState | SuccessData>(
       ...args: unknown[]
     ) {
       const [arg] = args
+      if (arg !== null && typeof arg === 'object' && !Object.keys(arg).length) {
+        throw new Error('No data to set')
+      }
       const data = await target.call(this, arg)
       const newData =
         String(context.name) === 'SetPower' ?

diff --git a/src/facades/base_super_device.ts b/src/facades/base_super_device.ts
@@ -38,9 +38,6 @@ export default abstract class<
   public async setAta(
     state: GroupAtaState,
   ): Promise<FailureData | SuccessData> {
-    if (!Object.keys(state).length) {
-      throw new Error('No data to set')
-    }
     try {
       return (
         await this.api.setAta({