Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csstudio 2421 advanced search #151

Merged
merged 4 commits into from
May 24, 2024
Merged

Conversation

cjenkscybercom
Copy link
Contributor

@cjenkscybercom cjenkscybercom commented May 22, 2024

Summary of Changes

Adds advanced search to the Beta UI

  • Opened via Filter icon
  • Opens in side drawer
  • Submits search on closing drawer or clicking Search button within drawer
  • When advanced search is active:
    • simple search field is hidden
    • filter icon shows count of searched fields to indicate number of active filters / search terms
    • doesn't send the simple search parameter ("query" for now, pending BE implementation)
  • Any search term (simple or advanced) is displayed in a Chip. Deleting the chip updates the search
  • Old UI doesn't mistakenly show beta parameters

Simple Search:
Screenshot 2024-05-23 at 15 54 09

Drawer:
Screenshot 2024-05-23 at 15 53 44

Filters active:
Screenshot 2024-05-23 at 15 54 30

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@cjenkscybercom cjenkscybercom self-assigned this May 22, 2024
@cjenkscybercom cjenkscybercom marked this pull request as draft May 23, 2024 07:24
@cjenkscybercom cjenkscybercom marked this pull request as ready for review May 23, 2024 13:53
Copy link
Member

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cjenkscybercom
Copy link
Contributor Author

Looks good

Thank you for taking a look, Georg!

@cjenkscybercom
Copy link
Contributor Author

Forgot to comment here for brevity -- ran the tests locally and they all pass.

@cjenkscybercom cjenkscybercom merged commit aa6206c into main May 24, 2024
3 of 6 checks passed
@cjenkscybercom cjenkscybercom deleted the CSSTUDIO-2421-advanced-search branch May 24, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants