Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2373: fix images not displayed in some cases #152

Merged
merged 1 commit into from
May 27, 2024

Conversation

cjenkscybercom
Copy link
Contributor

@cjenkscybercom cjenkscybercom commented May 24, 2024

Summary of Changes

In some cases, images don't display properly because their mime-type is image/{something} and a few pieces of code were asserting this was equal to "image" rather than starting with that text.

I'm aware there are two places in the code performing the check, however I'd rather plan tackling that in a separate body of work.

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@cjenkscybercom
Copy link
Contributor Author

Tests pass locally, please ignore flake.

Copy link
Member

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does one trigger the error case? Or, how do I verify the fix?

@cjenkscybercom
Copy link
Contributor Author

How does one trigger the error case? Or, how do I verify the fix?

Unfortunately I've not been able to reproduce it locally, it would have shown in the end-to-end tests otherwise. But, I do know that the check on the FE is definitely not correct.

@cjenkscybercom
Copy link
Contributor Author

Thanks Georg!

@cjenkscybercom cjenkscybercom merged commit 49c3373 into main May 27, 2024
2 of 6 checks passed
@cjenkscybercom cjenkscybercom deleted the CSSTUDIO-2373-fix-display-images branch May 27, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants