Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSSTUDIO-2461: fix fail to redirect on create, edit, reply #157

Merged
merged 2 commits into from
Jun 18, 2024
Merged

CSSTUDIO-2461: fix fail to redirect on create, edit, reply #157

merged 2 commits into from
Jun 18, 2024

Conversation

cjenkscybercom
Copy link
Contributor

Summary of Changes

  • adds redirect in create, edit, and reply to finally clause to ensure it always happens even when log verification fails
  • centralizes beta navigation to custom hook

All component and end-to-end tests pass, please ignore GitHub flake.

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@cjenkscybercom
Copy link
Contributor Author

All component and end to end tests pass, please ignore flake.

jacomago
jacomago approved these changes Jun 18, 2024
View reviewed changes
Copy link

@jacomago jacomago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjenkscybercom cjenkscybercom merged commit 1748ec8 into main Jun 18, 2024
4 of 6 checks passed
@cjenkscybercom cjenkscybercom deleted the CSSTUDIO-2461 branch June 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacomago jacomago jacomago approved these changes

@georgweiss georgweiss Awaiting requested review from georgweiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjenkscybercom @jacomago