Log entry group property not editable #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log1.getProperties().clear(); | ||
| log1 = ITUtilLogs.assertUpdateLog(log1); | ||
| log2 = ITUtilLogs.assertRetrieveLog("/" + log2.getId()); | ||
| assertEquals(1, log1.getProperties().size()); |
There was a problem hiding this comment.
It's good we check the logbook group property remains, however it may be more effective to also verify that other properties are operated on as expected? E.g. if the other properties are left alone but we attempt to change or delete the log group?
There was a problem hiding this comment.
I guess the other properties may be part of the update which makes it not known which changes to keep and which to stop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log entry group property should not be editable but remain if it exists.
Integration test made available
- @test void handleLogGroup() {