Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions src/lib/libraries/extensions/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ import gdxforConnectionSmallIconURL from './gdxfor/gdxfor-small.svg';

import twIcon from './tw/tw.svg';
import customExtensionIcon from './custom/custom.svg';
import serverIcon from './server/server.svg';
import returnIcon from './custom/return.svg';
import galleryIcon from './gallery/gallery.svg';
import {APP_NAME} from '../../brand';
Expand Down Expand Up @@ -162,6 +163,21 @@ export default [
featured: true,
internetConnectionRequired: true
},
{
name: 'Web Server',
extensionId: 'server',
collaborator: 'LibreKitten',
iconURL: serverIcon,
description: (
<FormattedMessage
defaultMessage="Build a web server that can host an API and simple websites."
description="Description for the 'Web Server' extension"
id="omni.extension.server.description"
/>
),
tags: ['ob'],
featured: true
},
Comment on lines 166 to 180
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Logic Error: Missing insetIconURL property for Web Server extension. All other extensions in the library include both iconURL and insetIconURL properties for proper display in different UI contexts. Without insetIconURL, the extension may not render correctly in compact views or cause runtime errors when the UI attempts to access this property.

Suggested change
{
name: 'Web Server',
extensionId: 'server',
collaborator: 'LibreKitten',
// TODO: This is a placeholder until someone designs a cover or Amp gives permission to use the he made one for
// LibreKitten.
iconURL: customExtensionIcon,
description: (
<FormattedMessage
defaultMessage="Build a web server that can host an API and simple websites."
description="Description for the 'Web Server' extension"
id="omni.extension.server.description"
/>
),
tags: ['ob'],
featured: true
},
{
name: 'Web Server',
extensionId: 'server',
collaborator: 'LibreKitten',
// TODO: This is a placeholder until someone designs a cover or Amp gives permission to use the he made one for
// LibreKitten.
iconURL: customExtensionIcon,
insetIconURL: customExtensionIcon,
description: (
<FormattedMessage
defaultMessage="Build a web server that can host an API and simple websites."
description="Description for the 'Web Server' extension"
id="omni.extension.server.description"
/>
),
tags: ['ob'],
featured: true
},

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine.

{
name: 'Makey Makey',
extensionId: 'makeymakey',
Expand Down
88 changes: 88 additions & 0 deletions src/lib/libraries/extensions/server/server.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading