Add option to control if the questions is required or not #166
Conversation
|
My first backend PR
|
There was a problem hiding this comment.
Code changes look great! I'd love to see two tests exercising these new changes: one in the relevant model spec, and one in the relevant request spec to ensure that we don't regress the behavior you've added in the future. LMK if you need clarity on what these tests should look like
Done |
| @@ -12,12 +12,13 @@ | |||
| sign_in admin | |||
| post admin_study_survey_questions_path(study, survey), | |||
| params: { | |||
| question: { content_attributes: { type: 'label', label_text: 'Question' } } | |||
| question: { content_attributes: { type: 'label', required: true, label_text: 'Question' } } | |||
There was a problem hiding this comment.
Can you change the value of required to false so we can verify that the value changes through the controller work as expected?
Fixes #165.
Added a checkbox to control if a question requires a response or not