feature/paginate-survey-responses #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
requested changes
Oct 7, 2024
Gemfile
Outdated
| @@ -10,6 +10,7 @@ gem "importmap-rails" | |||
| gem "jbuilder", '~>2.12' | |||
| gem 'jsonb_accessor', '~> 1.4' | |||
| gem 'mailgun-ruby', '~>1.2.14' | |||
| gem 'pagy' | |||
There was a problem hiding this comment.
please pin this to the major version, i.e.:
gem 'pagy', '~>9'
| <% end %> | ||
|
|
There was a problem hiding this comment.
please delete the blank lines at the end of the file
| @@ -14,6 +14,9 @@ | |||
| <meta name="apple-itunes-app" content="app-id=329380089"> | |||
| <%= stylesheet_link_tag "tailwind", "data-turbo-track": "reload" %> | |||
| <%= stylesheet_link_tag "application", "data-turbo-track": "reload" %> | |||
| <%= stylesheet_link_tag 'pagy.tailwind', media: 'all' %> | |||
There was a problem hiding this comment.
are these necessary since you included pagy.tailwind in the application.tailwind.css file?
There was a problem hiding this comment.
When I removed it, the pagy navigation bar was displayed without any style. But I just tried removing the import from application.tailwind.css and kept the pagy.tailwind link_tag application.html, and it works now.
aaronbrethorst
force-pushed
the
feature/paginate-survey-responses
branch
from
c9f3df3
to
5c77e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.