Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure: refactor #4

Merged
merged 2 commits into from
Jun 20, 2024
Merged

azure: refactor #4

merged 2 commits into from
Jun 20, 2024

Conversation

Altonhe
Copy link
Member

@Altonhe Altonhe commented Jun 20, 2024 •
edited
Loading

This PR update Azure implementation is based on Terraform best practice.

  • In the resource name, don't repeat the resource type, I changed them to main.
  • Declare all variables in variables.tf.
  • Move outputs to output.tf.
  • Using SSH key pairs instead of insecure passwords.

@Altonhe Altonhe marked this pull request as ready for review June 20, 2024 01:36
aaronbrethorst
aaronbrethorst approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Great work as always :)

@aaronbrethorst aaronbrethorst merged commit f650f9d into OneBusAway:main Jun 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Altonhe @aaronbrethorst