Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: add deployment on Render and DigitalOcean #8

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

Altonhe
Copy link
Member

@Altonhe Altonhe commented Aug 9, 2024

Heroku's support for Docker is more geared towards advanced use cases, and their Terraform provider doesn't natively support deploying Docker containers. Instead, Heroku is designed to build and deploy applications using their own build packs and tech stack. As a result, I have decided to remove Heroku from the options and focus on Render and DigitalOcean instead.

@Altonhe Altonhe marked this pull request as ready for review August 9, 2024 07:31
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'd like to see one small change in a README, but otherwise I think this is good to go! 🚀

modules/digitalocean-droplets/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

@aaronbrethorst aaronbrethorst merged commit b69af93 into OneBusAway:main Aug 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants