Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute "removeToday" to RemoveOldCalendarStatements #238

Merged

Conversation

tisseo-deploy
Copy link
Contributor

@tisseo-deploy tisseo-deploy commented May 13, 2024

Summary:

Solve Issue #233: Add attribute "removeToday" to RemoveOldCalendarStatements

@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

@tisseo-deploy tisseo-deploy changed the title 233 add remove today Add attribute "removeToday" to RemoveOldCalendarStatements May 13, 2024
@tisseo-deploy tisseo-deploy force-pushed the 233-add-remove-today branch from 9b137c5 to 6be06b3 Compare May 13, 2024 09:08
@leonardehrenfried
Copy link
Collaborator

Hi there, I'm the new maintainer of this library.

If you write a bit of documentation in /docs and perhaps even add a test, I can merge this in.

@leonardehrenfried
Copy link
Collaborator

Since you opened that PR, we have moved to Junit 5 therefore you need to rebase onto master.

@tisseo-deploy
Copy link
Contributor Author

Hi Leonard, thanks for your answer.
We are working on it right now, the PR is not ready.

@tisseo-deploy tisseo-deploy marked this pull request as draft December 4, 2024 08:49
@tisseo-deploy tisseo-deploy marked this pull request as ready for review December 5, 2024 13:00
@tisseo-deploy
Copy link
Contributor Author

Docs and tests OK

@leonardehrenfried
Copy link
Collaborator

Does it makes sense to delete today by default? I would say that keeping today would be useful to most people.

@tisseo-deploy
Copy link
Contributor Author

I agree with you. By the way, removing today's date might have been a bug in the original function.
But if we change it, the PR will change the default behavior. That's the only reason why we didn't do it.

Can you confirm that we should change the default value?

@leonardehrenfried
Copy link
Collaborator

Please change the default behaviour. I can list it as a breaking change.

…se in the remove old calendar statements operation
@leonardehrenfried leonardehrenfried merged commit dac31b7 into OneBusAway:master Dec 6, 2024
5 checks passed
@tisseo-deploy tisseo-deploy deleted the 233-add-remove-today branch December 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants