-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute "removeToday" to RemoveOldCalendarStatements #238
Add attribute "removeToday" to RemoveOldCalendarStatements #238
Conversation
9b137c5
to
6be06b3
Compare
Hi there, I'm the new maintainer of this library. If you write a bit of documentation in |
6aa1af3
to
3f0f297
Compare
Since you opened that PR, we have moved to Junit 5 therefore you need to rebase onto master. |
c2b2f7a
to
c17f67b
Compare
Hi Leonard, thanks for your answer. |
Docs and tests OK |
Does it makes sense to delete today by default? I would say that keeping today would be useful to most people. |
I agree with you. By the way, removing today's date might have been a bug in the original function. Can you confirm that we should change the default value? |
Please change the default behaviour. I can list it as a breaking change. |
…se in the remove old calendar statements operation
Summary:
Solve Issue #233: Add attribute "removeToday" to RemoveOldCalendarStatements