-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add comprehensive foldable device detection with caching #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huhuanming
wants to merge
12
commits into
main
Choose a base branch
from
feat/foldable-device-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive foldable device detection for Xiaomi, Huawei, Vivo, OPPO, Samsung, Google, Motorola, and ZTE/Nubia devices using model lists and manufacturer-specific APIs. Cache detection results in PreferenceManager with key "1k_fold" to avoid repeated detection. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add comprehensive foldable device models extracted from the Google Play supported_devices.csv, including: - Vivo X Fold5 (V2436A, V2429) - ZTE Libero Flip, nubia Flip 2 5G - Honor Magic V2/V3/V5/Vs series - Vertu METAFLIP - Tecno PHANTOM V Fold/Flip series - Infinix ZERO Flip - Royole VERTU Ayxta Fold 3 - Complete Samsung Galaxy Z Fold/Flip model numbers Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change return type from non-existent Variant_NullType_RecordResult to Promise<RecordResult?> to match HybridCloudKitModuleSpec interface. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Pin exact version (no caret prefix) across all subprojects: - native-modules/* - native-views/* - example/react-native - scripts/nitro/template - scripts/nitro-view/template - root package.json Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Change return type from Variant_NullType_RecordResult to Promise<RecordResult?> to match HybridCloudKitModuleSpec interface. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update both iOS and Android CloudKitModule implementations to use Variant_NullType_RecordResult instead of optional types, matching the nitrogen 0.31.10 generated spec. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
1k_foldSupported Manufacturers
persist.sys.muiltdisplay_typecom.huawei.hardware.sensor.postureandroid.util.FtDeviceInfoAPIOplusFeatureConfigManagerKey Changes
isDualScreenDevice()now checks PreferenceManager cache firstTest plan
🤖 Generated with Claude Code