Skip to content

feat: add comprehensive foldable device detection with caching #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huhuanming wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: add comprehensive foldable device detection with caching #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
24ef32a
Update ReactNativeDeviceUtils.kt
huhuanming Jan 11, 2026
d107e99
feat: add manufacturer-specific foldable device detection with caching
huhuanming Jan 28, 2026
549bee0
Update ReactNativeDeviceUtils.kt
huhuanming Jan 28, 2026
6a59fff
feat: expand foldable device list from Google Play supported devices
huhuanming Jan 28, 2026
b79b046
fix: correct fetchRecord return type in CloudKitModule
huhuanming Jan 29, 2026
731517d
chore: upgrade react-native-nitro-modules to 0.33.2
huhuanming Jan 29, 2026
92b445a
Update Podfile.lock
huhuanming Jan 29, 2026
797bcf8
fix: correct fetchRecord return type in iOS CloudKitModule
huhuanming Jan 29, 2026
b0dfc0a
patch version
huhuanming Jan 29, 2026
93a7085
fix: use Variant_NullType_RecordResult for fetchRecord return type
huhuanming Jan 29, 2026
faf69d6
Update Podfile.lock
huhuanming Jan 29, 2026
e368e45
version patch
huhuanming Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions example/react-native/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
PODS:
- BackgroundThread (1.1.11):
- BackgroundThread (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -28,7 +28,7 @@ PODS:
- SocketRocket
- Yoga
- boost (1.84.0)
- CloudKitModule (1.1.11):
- CloudKitModule (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -66,7 +66,7 @@ PODS:
- hermes-engine (0.14.0):
- hermes-engine/Pre-built (= 0.14.0)
- hermes-engine/Pre-built (0.14.0)
- KeychainModule (1.1.11):
- KeychainModule (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -96,7 +96,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- NitroModules (0.31.10):
- NitroModules (0.33.2):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2653,7 +2653,7 @@ PODS:
- React-perflogger (= 0.83.0)
- React-utils (= 0.83.0)
- SocketRocket
- ReactNativeCheckBiometricAuthChanged (1.1.11):
- ReactNativeCheckBiometricAuthChanged (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2683,7 +2683,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- ReactNativeDeviceUtils (1.1.11):
- ReactNativeDeviceUtils (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2713,7 +2713,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- ReactNativeGetRandomValues (1.1.11):
- ReactNativeGetRandomValues (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2743,7 +2743,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- ReactNativeLiteCard (1.1.11):
- ReactNativeLiteCard (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -2771,7 +2771,7 @@ PODS:
- ReactCommon/turbomodule/core
- SocketRocket
- Yoga
- Skeleton (1.1.11):
- Skeleton (1.1.15):
- boost
- DoubleConversion
- fast_float
Expand Down Expand Up @@ -3077,17 +3077,17 @@ EXTERNAL SOURCES:
:path: "../../../node_modules/react-native/ReactCommon/yoga"

SPEC CHECKSUMS:
BackgroundThread: d6bedf61338886caa616744dc1e4aa77656dc285
BackgroundThread: 8bfdbb6081771366de5e5e2b588aad1beafea9be
boost: 7e761d76ca2ce687f7cc98e698152abd03a18f90
CloudKitModule: febc66c8e919ad7f2f6e789af621dfaa0655e103
CloudKitModule: a7596fae8e1e2d05bd0ba2fa4d4ad90b5e93ea5a
DoubleConversion: cb417026b2400c8f53ae97020b2be961b59470cb
fast_float: b32c788ed9c6a8c584d114d0047beda9664e7cc6
FBLazyVector: a293a88992c4c33f0aee184acab0b64a08ff9458
fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
hermes-engine: 70fdc9d0bb0d8532e0411dcb21e53ce5a160960a
KeychainModule: 014ea2c49f4faa006a6e08b0ec6671875e830654
NitroModules: 5bc319d441f4983894ea66b1d392c519536e6d23
KeychainModule: 7a82d9b61fbd70183fdb991384e6a99eff8ac502
NitroModules: 11bba9d065af151eae51e38a6425e04c3b223ff3
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
RCTDeprecation: 2b70c6e3abe00396cefd8913efbf6a2db01a2b36
RCTRequired: f3540eee8094231581d40c5c6d41b0f170237a81
Expand Down Expand Up @@ -3158,11 +3158,11 @@ SPEC CHECKSUMS:
ReactAppDependencyProvider: ebcf3a78dc1bcdf054c9e8d309244bade6b31568
ReactCodegen: 554b421c45b7df35ac791da1b734335470b55fcc
ReactCommon: 424cc34cf5055d69a3dcf02f3436481afb8b0f6f
ReactNativeCheckBiometricAuthChanged: 39255aa18891d558cb015483cc76bd7a4dc85df8
ReactNativeDeviceUtils: adf7b3b1acc437360f7e2e13bcf5b6b74d8da0f8
ReactNativeGetRandomValues: 1f4deca887951794a2cd3e85276c18bb944ec315
ReactNativeLiteCard: 9b360619d69533b5e9aec940d3cdfb0d0c157f3a
Skeleton: b63a360c1f9f0c60e7938399d99bf25e151d6a46
ReactNativeCheckBiometricAuthChanged: 5757aec913dee03c7d488eebb6b05a91ff774e61
ReactNativeDeviceUtils: 2372c7f86169033f39b524b0bfc28323a2cf6bdc
ReactNativeGetRandomValues: 60a36d2a7e0ced4e37bbbc9faa98e11f27655518
ReactNativeLiteCard: d59be2b082bc3e7ef452095042c1e6b5483ab210
Skeleton: af32eaa6d321cf4f3266cf408dadec752dfb8e1d
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
Yoga: 6ca93c8c13f56baeec55eb608577619b17a4d64e

Expand Down
2 changes: 1 addition & 1 deletion example/react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"eslint": "^8.19.0",
"jest": "^29.6.3",
"prettier": "2.8.8",
"react-native-nitro-modules": "0.31.10",
"react-native-nitro-modules": "0.33.2",
"react-test-renderer": "19.2.0",
"typescript": "^5.8.3"
},
Expand Down
2 changes: 1 addition & 1 deletion native-modules/react-native-background-thread/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@onekeyfe/react-native-background-thread",
"version": "1.1.14",
"version": "1.1.16",
"description": "react-native-background-thread",
"main": "./lib/module/index.js",
"types": "./lib/typescript/src/index.d.ts",
Expand Down
6 changes: 3 additions & 3 deletions native-modules/react-native-check-biometric-auth-changed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@onekeyfe/react-native-check-biometric-auth-changed",
"version": "1.1.14",
"version": "1.1.16",
"description": "react-native-check-biometric-auth-changed",
"main": "./lib/module/index.js",
"types": "./lib/typescript/src/index.d.ts",
Expand Down Expand Up @@ -82,15 +82,15 @@
"react": "19.2.0",
"react-native": "0.83.0",
"react-native-builder-bob": "^0.40.13",
"react-native-nitro-modules": "0.31.10",
"react-native-nitro-modules": "0.33.2",
"release-it": "^19.0.4",
"turbo": "^2.5.6",
"typescript": "^5.9.2"
},
"peerDependencies": {
"react": "*",
"react-native": "*",
"react-native-nitro-modules": "^0.31.10"
"react-native-nitro-modules": "0.33.2"
},
"react-native-builder-bob": {
"source": "src",
Expand Down
2 changes: 1 addition & 1 deletion ...cloud-kit-module/android/src/main/java/com/margelo/nitro/cloudkitmodule/CloudKitModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class CloudKitModule : HybridCloudKitModuleSpec() {
}

override fun fetchRecord(params: FetchRecordParams): Promise<Variant_NullType_RecordResult> {
return Promise.resolved(Variant_NullType_RecordResult.First(NullType.NULL))
return Promise.resolved(Variant_NullType_RecordResult.create(NullType.NULL))
}

override fun deleteRecord(params: DeleteRecordParams): Promise<Unit> {
Expand Down
22 changes: 10 additions & 12 deletions native-modules/react-native-cloud-kit-module/ios/CloudKitModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ class CloudKitModule: HybridCloudKitModuleSpec {

// MARK: - Fetch Record

public func fetchRecord(params: FetchRecordParams) throws -> NitroModules.Promise<Variant_NullType_RecordResult> {
public func fetchRecord(params: FetchRecordParams) throws -> Promise<Variant_NullType_RecordResult> {
return Promise.async {
let ckRecordID = CKRecord.ID(recordName: params.recordID)

Expand All @@ -88,18 +88,16 @@ class CloudKitModule: HybridCloudKitModuleSpec {
let createdAt = Int64((record.creationDate?.timeIntervalSince1970 ?? 0) * 1000)
let modifiedAt = Int64((record.modificationDate?.timeIntervalSince1970 ?? 0) * 1000)

let result = Variant_NullType_RecordResult.second(
RecordResult(
recordID: record.recordID.recordName,
recordType: record.recordType,
data: data,
meta: meta,
createdAt: Double(createdAt),
modifiedAt: Double(modifiedAt))
)
return result
return Variant_NullType_RecordResult.second(RecordResult(
recordID: record.recordID.recordName,
recordType: record.recordType,
data: data,
meta: meta,
createdAt: Double(createdAt),
modifiedAt: Double(modifiedAt)
))
} catch let error as CKError where error.code == .unknownItem {
return Variant_NullType_RecordResult.first(NullType.null)
return Variant_NullType_RecordResult.first(NullType.null)
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions native-modules/react-native-cloud-kit-module/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@onekeyfe/react-native-cloud-kit-module",
"version": "1.1.14",
"version": "1.1.16",
"description": "react-native-cloud-kit-module",
"main": "./lib/module/index.js",
"types": "./lib/typescript/src/index.d.ts",
Expand Down Expand Up @@ -82,15 +82,15 @@
"react": "19.2.0",
"react-native": "0.83.0",
"react-native-builder-bob": "^0.40.13",
"react-native-nitro-modules": "0.31.10",
"react-native-nitro-modules": "0.33.2",
"release-it": "^19.0.4",
"turbo": "^2.5.6",
"typescript": "^5.9.2"
},
"peerDependencies": {
"react": "*",
"react-native": "*",
"react-native-nitro-modules": "^0.31.10"
"react-native-nitro-modules": "0.33.2"
},
"react-native-builder-bob": {
"source": "src",
Expand Down
Loading