Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:market-table-component-style #3550

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

oidsixer
Copy link

Fix Market list style issues: https://onekeyhq.atlassian.net/browse/OK-23367

  • [Hide] 24h Volume column
  • [Adjust] Increase minimum width of 24hChange column
  • [Adjust] Prevent line wrapping at all breakpoints

@oidsixer oidsixer requested a review from a team as a code owner September 18, 2023 10:35
@what-the-diff
Copy link

what-the-diff bot commented Sep 18, 2023

PR概述

  • 更改1-隐藏EMarketCellData.Token24hVolume相关的代码
    packages/kit/src/store/reducers/market.tspackages/kit/src/views/Market/Components/MarketList/MarketListHeader.tsxpackages/kit/src/views/Market/Components/MarketList/MarketTokenCell.tsxpackages/kit/src/views/Market/config.ts这四个文件中,我们都注释掉了与EMarketCellData.Token24hVolume相关的代码,从而实现了它的隐藏。

  • 更改2-调整ListHeadTags[0].minW的值
    我们在packages/kit/src/views/Market/config.ts这个文件中,将ListHeadTags[0].minW的值从'70px'调整到了'96px'

  • 更改3-添加hide824Width: true & hide924Width: true
    我们为packages/kit/src/views/Market/config.ts中的ListHeadTags[1]对象添加了hide824Width: truehide924Width: true这两个属性。

@ezailWang ezailWang enabled auto-merge (squash) October 12, 2023 03:56
@ezailWang ezailWang merged commit d041248 into OneKeyHQ:onekey Oct 12, 2023
21 of 25 checks passed
@oidsixer oidsixer deleted the fix/market-table-component-style branch October 12, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants