OK-23494: Restrict protocols for webview navigation #3622
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
loatheb
requested changes
Oct 10, 2023
| // Supported thrid party wallets which was registered in info.plist | ||
| 'fireblocks-wc:' as const, | ||
| 'zerion:' as const, | ||
| 'rainbow:' as const, |
There was a problem hiding this comment.
发现页也能打开 deeplink 吗？发现页只能打开 https 网页吧
There was a problem hiding this comment.
以及用 will-navigate 最好等 electron 版本升级之后再合入，因为不同的 electron 版本，webview 和主进程 API 差异都蛮大的，现在这个版本生效，不一定升级后的版本也能生效
There was a problem hiding this comment.
发现页也能打开 deeplink 吗？发现页只能打开 https 网页吧
这是主分支里 Native webview 的逻辑，只要链接正确，是能通过 universal link 唤起第三方 App 的
There was a problem hiding this comment.
以及用 will-navigate 最好等 electron 版本升级之后再合入，因为不同的 electron 版本，webview 和主进程 API 差异都蛮大的，现在这个版本生效，不一定升级后的版本也能生效
webviewTag 拦截的手法不多，因为它是不支持在自身的 will-navigate 事件中 preventEvent 的。
这里是在主进程统一对 webview 类型的 will-navigate 做了拦截，目前自测没问题
如果这个 issue 不着急的话就先 draft pr 了，升级完之后再自测下
Bundle Stats-web bundle diffHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed
Bigger
Smaller
Unchanged
|
Bundle Stats-ios bundle diffHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.