Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:change-app-icon #3624

Closed
wants to merge 3 commits into from

Conversation

oidsixer
Copy link

Change App icon assets

Not included:

  • SplashScreen
  • components / src / Icon / react / illus / BrandLogo

@oidsixer oidsixer requested a review from a team as a code owner October 10, 2023 13:27
@what-the-diff
Copy link

what-the-diff bot commented Oct 10, 2023

PR Summary

  • Updated App's Icons and Images
    A number of images and icons used within the application have been added or updated. This change applies to both the iOS and desktop versions of the app, as well as the web-embed and web versions.

  • ServiceApp Amendments
    In the ServiceApp file (a key service management component of our application), there have been a couple of modifications:

    • We have adjusted the way the app handles notifications. Before, the function was awaited; now, the function runs without waiting for the operation to complete.
    • After running an operation to close all web tabs, a new function has been added to clear ('purge') stored data.
  • Changes in Modal Imports
    Some modifications have been made in the RootModal and RootApp files. These involve commenting out (disabling) the import of certain modal components - ‘ManagerWalletModal’ and ‘ModalStackNavigator’. This could relate to a reorganization of how these modal components function, a removal or a change in their usage.

@oidsixer oidsixer force-pushed the optimize/change-app-icon branch from b1ea6cd to c8040d9 Compare October 11, 2023 06:20
@oidsixer oidsixer marked this pull request as draft October 11, 2023 11:55
@loatheb loatheb closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants