Fix XML import when only one site exists #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed XML import when only one site exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only one site exists in ADSites.xml, it doesn't import as an array. This results in
$FirstSite = $ADSites.ADSites.Site[0]being empty, which causes the script to skip over renaming Default-First-Site-Name and add the site specified in ADSites.xml as a separate site. The domain controller would have to be manually switched to the new site.I switched to the SelectNodes function for importing and adjusted the appropriate variables. I've tested this with a single entry and multiple entries in ADSites.xml and it works without issue. I also changed the log message to more accurately reflect what it's doing.