Fix notification foreground listener preventing notification display #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This PR fixes a bug that prevented notifications after the first one from displaying when the foreground listener is set.
Details
notificationWillShowInForegoundCallbackId
is set over the bridge when the developer calls to add their notification foreground listener.Motivation
Fixes #943
Scope
We were overwriting this
notificationWillShowInForegoundCallbackId
. It is set when app developers call the add listener method to add their listener, so it can hook back to their listener.Testing
Manual testing
iPhone 13 on iOS 17.2
✅ All foreground notifications display if I did not call
preventDefault()
✅ If multiple listeners are added, they are all triggered
✅ Listener calls
preventDefault()
and thendisplay()
5 seconds later will display the notification after 5 seconds✅ Listener calls
preventDefault()
and notification never displaysAffected code checklist
Checklist
Overview
Testing
Final pass
This change is