Skip to content

refactor : 예외처리 수정 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DG0702 merged 1 commit into from
Jun 20, 2025
Merged

refactor : 예외처리 수정 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/com/example/onederful/domain/user/repository/UserRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
import java.util.Optional;

public interface UserRepository extends JpaRepository<User, Long> {
boolean existsByEmail(String email);
boolean existsByUsername(String username);
Optional<User> findByEmail(String email);
Optional<User> findByUsername(String username);

}
13 changes: 6 additions & 7 deletions src/main/java/com/example/onederful/domain/user/service/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,14 @@ public class UserService {
public UserResponseDto signup(RequestDto dto){

// 이메일 중복 확인
if(userRepository.existsByEmail(dto.getEmail())){
throw new CustomException(ErrorCode.DUPLICATE_EMAIL);
}

userRepository.findByEmail(dto.getEmail()).ifPresent(
user -> {throw new CustomException(ErrorCode.DUPLICATE_EMAIL);}
);

// 아이디 중복 확인
if(userRepository.existsByUsername(dto.getUsername())){
throw new CustomException(ErrorCode.DUPLICATE_USER);
}
userRepository.findByUsername(dto.getUsername()).ifPresent(
user -> {throw new CustomException(ErrorCode.DUPLICATE_USER);}
);

// Dto → Entity
User user = UserMapper.user(dto);
Expand Down