Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat skos:definition and rdfs:comment #50

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

ChristophB
Copy link
Member

@ChristophB ChristophB commented Dec 5, 2024

Line breaks in rdfs:comments have been fixed as well.

@ChristophB ChristophB linked an issue Dec 5, 2024 that may be closed by this pull request
between which a transition takes place. These contradictions refer to
some collection of pairwise disjoint universals.</skos:definition>
<skos:definition rdf:datatype="http://www.w3.org/2001/XMLSchema#string">A change in the technical sense refers to a pair of process boundaries. Either at coinciding boundaries (then it comes close to notions like ``punctual'' or ``instantaneous event'' as well as ``moment'' -- in a temporal reading), or at boundaries at the opposite ends of a process of arbitrary extension.
The notion of change is relative to contradictory conditions between which a transition takes place. These contradictions refer to some collection of pairwise disjoint universals.</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should never be a newline in a definition, because they are interpreted differently between operating systems and might interfere with programs which display the ontology later on.

Copy link
Member Author

@ChristophB ChristophB Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you suggest? I don't want to get too involved in the OWL file, as I'm not the original author. &#10; is another option. But honestly, Protégé also just puts "\n" in the file.

Copy link
Contributor

@k00ni k00ni Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick Internet search I was not able to find any example or statement which supports what I am suggesting, so its more of a personal opinion. But as stated above, avoid newlines whenever possible might help with later processing because

  • of issues, such as in Add GFO-light minimal version #34 (comment) (line endings in Windows)
  • changed line endings might also lead to "bloated" commit-diffs, because Git thinks something changed when in fact only the editor used the operating systems default when saving a file

However, there is no need to invest more time than necessary. Just my two cents, because you picked up my comment from #42 (comment) and seemed you wanna get rid of all the newlines in the first place.

modules/gfo-base.owl Outdated Show resolved Hide resolved
Co-authored-by: Konrad Abicht <hi@inspirito.de>
@ChristophB ChristophB requested a review from AlexU75 December 5, 2024 16:25
@ChristophB ChristophB merged commit 4b85f3b into main Dec 11, 2024
1 check passed
@ChristophB ChristophB deleted the 49-fix-line-breaks-of-skosdefinition branch December 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix line breaks of skos:definition
3 participants