Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDOP]: Add setters for most TC object values #304

Merged
merged 1 commit into from
Aug 17, 2023
Merged

[DDOP]: Add setters for most TC object values #304

merged 1 commit into from
Aug 17, 2023

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Aug 16, 2023

  • This allows modifying some DDOP objects after they're created, whereas previously you couldn't modify them once constructed.

As far as I know, there wasn't really a reason to disallow changing most of the objects' fields, and allowing it makes real-time editing of the DDOP a lot easier.

@ad3154 ad3154 added the enhancement New feature or request label Aug 16, 2023
@ad3154 ad3154 self-assigned this Aug 16, 2023
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 16, 2023 23:38 — with GitHub Actions Inactive
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 16, 2023 23:53 — with GitHub Actions Inactive
This allows modifying some DDOP objects after they're created, whereas
previously you couldn't modify them once constructed.
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 16, 2023 23:55 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.5% 98.5% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ad3154 ad3154 requested a review from GwnDaan August 17, 2023 15:13
@ad3154 ad3154 merged commit 1e32900 into main Aug 17, 2023
6 checks passed
@ad3154 ad3154 deleted the ddop-setters branch August 17, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants