Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core]: Added a way to get callbacks when any CF goes online or offline #308

Merged
merged 2 commits into from
Sep 2, 2023
Merged

[Core]: Added a way to get callbacks when any CF goes online or offline #308

merged 2 commits into from
Sep 2, 2023

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Aug 27, 2023 •
edited
Loading

What's New:

  • This addresses issue Callback for partner function status changes #210 and provides a way to get callbacks from the network manager when a control function changes state.
  • Overall, this reduces the need to poll the state of your partners in a consuming application.
  • Also fixed some typos.

Closes #210

@ad3154 ad3154 added the enhancement New feature or request label Aug 27, 2023
@ad3154 ad3154 self-assigned this Aug 27, 2023
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 27, 2023 19:04 — with GitHub Actions Inactive
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 27, 2023 19:20 — with GitHub Actions Inactive
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 27, 2023 19:30 — with GitHub Actions Inactive
@ad3154 ad3154 temporarily deployed to Integrate Pull Request August 27, 2023 19:32 — with GitHub Actions Inactive
@ad3154 ad3154 requested a review from GwnDaan August 27, 2023 19:37
@ad3154
[Core]: Added a way to get callbacks when any CF goes online or offline
b0ff083 
This addresses issue #210 and provides a way to get callbacks from
the network manager when a control function changes state.
Overall this reduces the need to poll the state of your partners in a
consuming application.
@ad3154
[Core]: Changed control function state callbacks to work for all CFs
a2b008c 
Added suggestion from GwnDaan to have the CF state callbacks provide
callbacks for all CFs rather than specific ones.
@ad3154 ad3154 temporarily deployed to Integrate Pull Request September 2, 2023 01:08 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

69.1% 69.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ad3154 ad3154 requested a review from GwnDaan September 2, 2023 01:18
@ad3154 ad3154 merged commit 1cfe565 into main Sep 2, 2023
5 of 6 checks passed
@ad3154 ad3154 deleted the cf-state-callbacks branch September 2, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GwnDaan GwnDaan GwnDaan approved these changes

Assignees

@ad3154 ad3154

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callback for partner function status changes
2 participants
@ad3154 @GwnDaan