[CI]: remove approve step and upgrade sonar #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwnDaan
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
Also made windows and mac-os run tests
GwnDaan
force-pushed
the
daan/ci-upgrade-sonar
branch
from
1ef5312
to
b6a3584
Compare
GwnDaan
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
GwnDaan
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
|
Okay, I think the changes worked! Apart from some tests on Windows and Mac failing? But that's probably out of scope for this PR... @ad3154 if you approve these changes, the |
|
Kudos, SonarCloud Quality Gate passed!
|
ad3154
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1tov2, I assume this will fix the Java version warning (replaces [CI]: Attempt to resolve Sonar Java version warning #309)pull_requestwe don't risk any future security risks. I think this outweighs the drawback that PR's created from forks do not run the Sonar analysis (though they will build, test and lint immediately). Opinions on this welcomeNote that I haven't tested this