Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Sonar Cleanup #501

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Various Sonar Cleanup #501

merged 1 commit into from
Nov 8, 2024

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Nov 5, 2024

Describe your changes

This should clean up a number of issues reported by Sonar recently since #400

How has this been tested?

Most of these changes aren't really functional, they're just style and things like const

  • Unit tests
  • Updated sonar report improved
  • Build and run examples

@ad3154 ad3154 added enhancement New feature or request ci/build system Issue relates to build pipeline or other CI unit tests Related to unit testing labels Nov 5, 2024
@ad3154 ad3154 self-assigned this Nov 5, 2024
@ad3154 ad3154 marked this pull request as draft November 5, 2024 06:37
Copy link

sonarcloud bot commented Nov 5, 2024

@ad3154 ad3154 requested a review from GwnDaan November 5, 2024 23:58
@ad3154 ad3154 marked this pull request as ready for review November 5, 2024 23:58
@ad3154 ad3154 merged commit 4a243de into main Nov 8, 2024
10 checks passed
@ad3154 ad3154 deleted the sonar-cleanup branch November 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build system Issue relates to build pipeline or other CI enhancement New feature or request unit tests Related to unit testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants