[WS]: Allow UTF-16 string variables to be deserialized #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display of the string is the responsibility of the consuming application so there's no reason to deny a UTF-16 string here.
ad3154
added
enhancement
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This changes the deserializer for VT object pools to allow UTF-16 strings. Display of the string is the responsibility of the consuming application so there's no reason to deny a UTF-16 string here.
Once this is merged in I can finish the associated issue in AgIsoVirtualTerminal.
How has this been tested?
Tested by deserializing an object pool with a UTF-16 string in it which was provided by a community member in our Telegram group.