Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW]: Fix some issues when compiling with MinGW #503

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Nov 6, 2024

Describe your changes

Related to this issue on AgIsoVirtualTerminal.

Fixed some compilation issues which happen on Windows when compiling with MinGW. Specifically, the innomaker driver is not compatible with it seemingly due to how it was compiled, and also std::this_thread was not getting defined in the sys_tec plugin.

@ad3154 ad3154 added the os: windows Related to usage on Windows label Nov 6, 2024
@ad3154 ad3154 self-assigned this Nov 6, 2024
@ad3154 ad3154 requested a review from GwnDaan November 6, 2024 00:49
Fixed some compilation issues which happen on Windows when compiling
with MinGW. Specifically, the innomaker driver is not compatible with it
seemingly due to how it was compiled, and also std::this_thread was
not getting defined in the sys_tec plugin.
Copy link

sonarcloud bot commented Nov 8, 2024

@ad3154 ad3154 merged commit e656858 into main Nov 8, 2024
10 checks passed
@ad3154 ad3154 deleted the adrian/mingw-support branch November 8, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Related to usage on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant