Fixes: various fixes for payload loading, mocked responses #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Dec 11, 2024
| @@ -35,6 +35,8 @@ def test_endpoint( | |||
| method: str = "GET", | |||
| expected_status_codes: Union[list[int], int] = [200], | |||
| return_response: bool = False, | |||
| mock_response_content: bytes = None, | |||
There was a problem hiding this comment.
I don't seem to find where this mock_response_content is being used, is it necessary to add this?
| except Exception as e: | ||
| _log.error(f"Failed to create process graph: {e}") | ||
| print(f"Failed to create process graph: {e}") |
There was a problem hiding this comment.
just doing a print on any exception seems like asking for trouble down the line. Why not fail hard just here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: various tests had problems with loading payloads.
Added: functionality to use mocked response data to quickly test what in a response needs to be changetd