Skip to content

Comments

Restore camera reset key binding#30

Open
Sreoshh wants to merge 2 commits intoOpen-Source-Chandigarh:mainfrom
Sreoshh:fix-camera-reset
Open

Restore camera reset key binding#30
Sreoshh wants to merge 2 commits intoOpen-Source-Chandigarh:mainfrom
Sreoshh:fix-camera-reset

Conversation

@Sreoshh
Copy link

@Sreoshh Sreoshh commented Jan 19, 2026

Summary

This PR restores the camera reset functionality

What is Changed:

Pressing R now:
Resets the camera to its default position and resets the orientation to face the scene center.
The fix is implemented using the existing input binding system and the camera’s public reset API, keeping the change minimal and isolated.

@dhruv0154
Copy link
Collaborator

Summary

This PR restores the camera reset functionality

What is Changed:

Pressing R now: Resets the camera to its default position and resets the orientation to face the scene center. The fix is implemented using the existing input binding system and the camera’s public reset API, keeping the change minimal and isolated.

Hi @Sreoshh, Great work noticing that the implementation for reset was already there! I have tested it this works as expected but can you change the commit message to follow the Conventional Commits Style, like for camera it will be feat(camera): add key to reset camera pos."

@Sreoshh
Copy link
Author

Sreoshh commented Jan 20, 2026

Updated according to the conventional style would keep in mind from next time. Also if helpful, I can follow this up by making camera reset defaults configurable which is otherwise hardcoded.

@dhruv0154
Copy link
Collaborator

dhruv0154 commented Jan 20, 2026

Updated according to the conventional style would keep in mind from next time. Also if helpful, I can follow this up by making camera reset defaults configurable which is otherwise hardcoded.

Thank you! Go ahead with configurable implementation. @Sreoshh I will merge your PR once you are done.

@Sreoshh
Copy link
Author

Sreoshh commented Jan 21, 2026

@dhruv0154 I’ve pushed the required changes for the default values to be configurable. Kindly let me know if anything else needs to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants