feat: Complete Editor Suite (UI, Persistence, JSON config) & Render Fixes by r-baruah · Pull Request #33 · Open-Source-Chandigarh/pyre

r-baruah · 2026-02-07T07:38:10Z

This PR implements the full Editor tooling, along with the persistence system and several rendering fixes.

Key Changes

Visual Editor (ImGui)

Hierarchy: Added entity list with selection/deselection and manual Save/Load buttons.
Inspector: Can now edit Transforms and Materials. Added proper tooltips and 48x48 texture previews for materials.
Lighting: Panel to add, toggle, or delete Point Lights dynamically.
Settings: Controls for Post-Processing (Bloom, Tone Mapping) and Debug views (Normals, Wireframe).

Persistence (JSON)

Implemented SceneSerializer using nlohmann/json.
Saves Entities, Material Overrides, Lights, and PP settings.
Added logic to auto-create the scenes/ directory to prevent crashes on first save.

Rendering Fixes

Selection Outline: Moved to a dedicated post-render pass using the stencil buffer. This fixes the depth issues and prevents the outline from being blurred by Bloom.
Debug Normals Moved to a separate forward pass so they aren't distorted by HDR/Tone Mapping.
Fixed an incomplete framebuffer error when using MSAA with multiple attachments.

Input & UX

Implemented "Hold RMB to Look" camera behavior.
Added Ctrl+S (Save) and Ctrl+O (Load) shortcuts.
Fixes UX improvement: Replace 'Toggle' Mouse Capture with 'Hold-to-Look' #34 (Toggle mouse capture replaced with hold-to-look)
Input bindings are now loaded from resources/config/input.json.
Upgraded GLFW to 3.4 in CMake to support the newer ImGui backend features.

…selection

…processing

…ne tuning

…handigarh#34 - RMB hold captures mouse for camera rotation - RMB release shows cursor for UI interaction - Respects ImGui.WantCaptureMouse/Keyboard - Cursor visible by default (editor mode) - Removed obsolete ESC toggle binding

…ss post-processing

…rsistence

…ts and MSAA

…editing

…n on selection

Previously, the renderer used the raw loop index when generating point shadow maps, regardless of whether a light was enabled or disabled. the LightManager packs only active lights into the UBO (contiguous memory), but the shadow pass was skipping indices. This mismatch caused the shader to read light data at index N but sample a shadow map layer intended for a different light index, resulting in detached or missing shadows. fixed by introducing a decoupled shadowLayerIndex that only increments for enabled lights, ensuring the shadow map array matches the UBO structure.

Improved performance (Fps) by adding a proxy mesh for high poly meshes like the backpack in the model loading scene, disabled vsync.

This allows the SceneSerializer to retrieve the original file path when saving the scene, enabling texture persistence across sessions.

- Added logic to save and restore texture paths/types for MaterialOverrides. - Includes texture type to string conversion helpers. - Filters out procedural textures like cubemaps from serialization. - Uses ResourceManager to automatically reload textures on scene deserialization.

- Added 'Remove' button for textures with deferred removal logic. - Improved 'Load Texture' popup with TextureType selection (Diffuse/Specular/Normal etc). - Ensured material properties default to neutral values (White/32.0f) on creation. - Clean up texture UV display and added tooltips for better UX.

…ite)

…ss pipeline

…ht serialization

…rial controls

…pass implementation - Replaced 3-shader pipeline with optimized 1-shader Mask pass. - Reduced resource footprint (2 dedicated FBOs -> 1 shared R8 FBO). - Implemented resolution-adaptive thickness for consistent UI scaling.

r-baruah force-pushed the dev branch from b9f2461 to 80df2cb Compare February 8, 2026 15:10

r-baruah added 29 commits February 9, 2026 12:47

feat: initialize imgui context and backends

2a78766

feat(scene): add GetEntities accessor for imgui editor integration

b776f0a

feat(scenes): add descriptive entity names for scene hierarchy panel

1ab7858

feat(editor): add scene hierarchy and inspector panels with enhanced …

9918dbd

…selection

feat(scenes): add descriptive names for factory and test scenes

bdc3624

feat(postprocessing): add enabled flag and naming to post-effects

ee114d6

feat(renderer): add global debug flags for normals and outlines

4243d63

feat(scene): add GetPostPipeline accessor

9f2901d

feat(editor): implement global settings panel for rendering and post-…

b1a0943

…processing

feat(lighting): add accessors for directional light properties

8cbea44

feat(editor): implement lighting manipulation panel for real-time sce…

cc89e46

…ne tuning

feat(appstate): add selectedEntity for editor selection tracking

6949d79

feat(renderer): add selection highlighting with x-ray outline effect

998f437

feat(scene): pass selectedEntity to renderer for visual feedback

2f894f6

feat(editor): implement material runtime editor with override creation

8d18daa

feat(scene): add entity management helpers for serialization

25a568d

feat(persistence): add SceneSerializer for JSON save/load

1b59e26

feat(editor): add Save/Load buttons to Scene Hierarchy panel

dd1dc2c

feat(persistence): add light serialization (directional + point)

e0edf53

feat(editor): Save/Load now includes lights

e817a1f

feat(input): add InputMapper for JSON keybind config

8f23f5b

config: add default input keybindings

3cf77cd

feat(app): integrate InputMapper for configurable keybindings

3caf14e

build: upgrade GLFW to 3.4 for ImGui compatibility

49a1998

fix(renderer): refactor selection highlight and debug normals to bypa…

35fc291

…ss post-processing

feat(editor): implement deselection, shortcuts, and inspector polish

0c12bdb

feat(lighting): add enabled toggles and dynamic light management

8e40776

feat(serializer): implement directory auto-creation and full state pe…

c451e60

…rsistence

r-baruah added 2 commits February 9, 2026 12:58

fix(renderer): resolve incomplete framebuffer with multiple attachmen…

601f58c

…ts and MSAA

refactor(editor): use GetUniqueMaterial for entity-specific property …

7c1f969

…editing

r-baruah force-pushed the dev branch from 215fcb3 to 7c1f969 Compare February 9, 2026 07:34

r-baruah changed the title ~~feat(editor): Implement Scene Hierarchy, Inspector, and Interaction~~ feat: Complete Editor Suite (UI, Persistence, JSON config) & Render Fixes Feb 9, 2026

r-baruah and others added 19 commits February 9, 2026 16:33

fix(shaders): add outlineWidth uniform for vertex normal extrusion

9b523c4

fix(renderer): improve selection highlight with stencil and blend fixes

c3105bc

fix(lights): initialize PointLight struct members with safe defaults

ffa88de

fix(scene): use unique entity names to prevent serialization conflicts

4741291

fix(serializer): handle duplicate entities during deserialization

cf10e76

fix(editor): initialize material defaults and prevent color corruptio…

381a530

…n on selection

refactor(rendering): add proxy model for shadows.

4463b4d

Improved performance (Fps) by adding a proxy mesh for high poly meshes like the backpack in the model loading scene, disabled vsync.

fix(resource): store file path in Texture objects during load

0045eb4

This allows the SceneSerializer to retrieve the original file path when saving the scene, enabling texture persistence across sessions.

fix(serializer): solve texture removal persistence issues

7229941

feat(editor): remove redundant texture slot field

a22fa48

feat(shaders): add screen-space outline shaders (mask, dilate, compos…

0f46711

…ite)

feat(shader): add setVec2 uniform setter for outline texel size

ba8a901

feat(renderer): replace stencil outlines with screen-space post-proce…

dc7d17f

…ss pipeline

fix(serializer): add null-safety, cullmode, transparency, and spotlig…

1d6ef1e

…ht serialization

feat(editor): improve UI with scene switcher, status toasts, and mate…

d665bf7

…rial controls

r-baruah force-pushed the dev branch from c0ed613 to 387a720 Compare February 19, 2026 08:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Complete Editor Suite (UI, Persistence, JSON config) & Render Fixes#33

feat: Complete Editor Suite (UI, Persistence, JSON config) & Render Fixes#33
r-baruah wants to merge 50 commits intoOpen-Source-Chandigarh:devfrom
r-baruah:dev

r-baruah commented Feb 7, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

r-baruah commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Key Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

r-baruah commented Feb 7, 2026 •

edited

Loading