23 r re #24
23 r re #24
Conversation
| @@ -1,2 +1,2 @@ | |||
| Simulated versus observed concentration-time profiles of all data listed in [Section 2.2.2](#222-clinical-data) are presented below. | |||
| Simulated versus observed concentration-time profiles of all data listed in [Section 2.2.2](#clinical-data) are presented below. | |||
There was a problem hiding this comment.
use section reference (defined in the qualification plan) instead of the url generated from the title
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| **Baneyx 2014** Baneyx, G., Parrott, N., Meille, C., Iliadis, A. & Lavé, T. Physiologically based pharmacokinetic modeling of CYP3A4 induction by rifampicin in human: influence of time between substrate and inducer administration. Eur. J. Pharm. Sci. 56, 1–15 (2014). | |||
|
|
|||
| **DrugBank DB00802** https://www.drugbank.ca/drugs/DB00802, accessed 05-15-2020. | |||
| **DrugBank DB00802** [https://www.drugbank.ca/drugs/DB00802](https://www.drugbank.ca/drugs/DB00802), accessed 05-15-2020. | |||
There was a problem hiding this comment.
❗
Always better to use the markdown link formatting instead of putting the url directly in text
(e.g. when just putting as text: the hyperlink is not created in word/pdf report and not properly checked by some url checkers)
| @@ -1,34 +1,34 @@ | |||
| ### 2.2.1 In vitro / physicochemical Data | |||
| ### In vitro / physicochemical Data | |||
There was a problem hiding this comment.
Chapter numbers must be removed in the static content files as well!
| @@ -14,4 +14,4 @@ | |||
|
|
|||
| This evaluation report and the corresponding PK-Sim project file are filed at: | |||
|
|
|||
| https://github.com/Open-Systems-Pharmacology/OSP-PBPK-Model-Library/ | |||
| [https://github.com/Open-Systems-Pharmacology/OSP-PBPK-Model-Library/](https://github.com/Open-Systems-Pharmacology/OSP-PBPK-Model-Library/) | |||
There was a problem hiding this comment.
same as above: using hyperlinks in md-format ([text](url)) should always be used instead of just url
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "$schema": "https://github.com/Open-Systems-Pharmacology/QualificationPlan/releases/download/v2.1/OSP_Qualification_Plan_Schema.json", | |||
| "$schema": "https://github.com/Open-Systems-Pharmacology/QualificationPlan/releases/download/v3.0/OSP_Qualification_Plan_Schema.json", | |||
| @@ -123,74 +123,77 @@ | |||
| { | |||
| "Project": "Alfentanil", | |||
| "Simulation": "Ferrier 1985, Alfentanil iv 0.05 mg/kg", | |||
| "SectionId": 331 | |||
| "SectionReference": "ct-profiles-model-building" | |||
There was a problem hiding this comment.
use section reference instead of section id everywhere
| "PlotTypes": [ | ||
| "predictedVsObserved", | ||
| "residualsOverTime" | ||
| ], |
There was a problem hiding this comment.
use PlotTypes (array) instead of PlotType (string).
| "Kharasch 2011b - Alfentanil IV Control simultaneous - Alfentanil - IV - 1 mg - Plasma - agg. (n=6)", | ||
| "Kharasch 2011b - Alfentanil IV Grapefruit coadmin sequential - Alfentanil - IV - 1 mg - Plasma - agg. (n=6)", | ||
| "Kharasch 2011b - Alfentanil IV Grapefruit coadmin simultaneous - Alfentanil - IV - 1 mg - Plasma - agg. (n=6)" | ||
| ], |
There was a problem hiding this comment.
use array of observed data instead of duplication.
Can be used only if all other properties (project, simulation, output, color,...) are the same - which was the case here
| "Id": 1, | ||
| "Title": "1 Introduction", | ||
| "Reference": "introduction", | ||
| "Title": "Introduction", |
There was a problem hiding this comment.
- Use
Referenceinstead ofIdin every section - Remove chapter number from the title
| "Title": "2 Methods", | ||
| "Content": "Content/Section2_Methods.md", | ||
| "Reference": "methods", | ||
| "Title": "Methods", |
There was a problem hiding this comment.
no need to refer empty content files anymore. IF the chapter has only subchapters but no content - just remove the "Content" field.
| "Id": 5, | ||
| "Title": "5 References", | ||
| "Reference": "main-references", | ||
| "Title": "References", |
There was a problem hiding this comment.
I prefer to define the Reference for this chapter as "main-references" and not just "references" to avoid potential collisions (if other chapters have their own references section)
| @@ -0,0 +1,160 @@ | |||
| #' @title createQualificationReport | |||
There was a problem hiding this comment.
workflow.R here is almost 1:1 copy of the template provided with the ospsuite.reportingengine package.
The only thing I needed to do: replace "qualification_plan.json" with "evaluation_plan.json"
| @@ -1,8102 +1,8297 @@ | |||
| { | |||
There was a problem hiding this comment.
Lot of changes here due to the snapshot conversion.
To see the significant changes (consolidation of protein expression profiles) - refer to this commit:
00beb5b
No description provided.