Fixes #470 issue with obs data (#471)

Open-Systems-Pharmacology · Nov 27, 2018 · 5c9987e · 5c9987e
1 parent d94a342
commit 5c9987e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/OSPSuite.Presentation/Presenters/ObservedData/DataRepositoryDataPresenter.cs b/src/OSPSuite.Presentation/Presenters/ObservedData/DataRepositoryDataPresenter.cs
@@ -90,6 +90,9 @@ public void AddData(int rowIndex)
       /// <returns></returns>
       public IEnumerable<string> GetCellValidationErrorMessages(int rowIndex, int columnIndex, string newValue)
       {
+         if (string.IsNullOrWhiteSpace(newValue))
+            return new[] {Error.ValueIsRequired};
+
          var proposedValue = newValue.ConvertedTo<float>();
          var editedColumnId = GetColumnIdFromColumnIndex(columnIndex);
 

diff --git a/tests/OSPSuite.Core.Tests/Presentation/DataRepositoryDataPresenterSpecs.cs b/tests/OSPSuite.Core.Tests/Presentation/DataRepositoryDataPresenterSpecs.cs
@@ -145,6 +145,24 @@ public void should_not_return_validation_messages()
       }
    }
 
+   public class When_getting_validation_messages_for_an_empty_value : concern_for_DataRepositoryDataPresenter
+   {
+      private List<string> _result;
+
+      protected override void Because()
+      {
+         sut.EditObservedData(_dataRepository);
+         _result = sut.GetCellValidationErrorMessages(0, 1, "    ").ToList();
+      }
+
+      [Observation]
+      public void should_return_validation_messages()
+      {
+         _result.Count.ShouldBeEqualTo(1);
+         _result[0].ShouldBeEqualTo(Error.ValueIsRequired);
+      }
+   }
+
    public class When_getting_validation_messages_for_repeated_basegrid_values : concern_for_DataRepositoryDataPresenter
    {
       private List<string> _result;