Skip to content

Fixes #10 Migrate quali workflow Matlab=>R #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 3, 2025

Conversation

Yuri05
Copy link
Member

@Yuri05 Yuri05 commented Jun 20, 2025

Yuri05 added 18 commits June 3, 2025 14:07
Replaced Workflow.m with workflow.R
Adjusted qualification_plan.json to the latest qualification schema version
Upgraded used models to the latest versions
Upgraded used observed data to the latest version
Upgraded used text modules to the latest version
Replaced Workflow.m with workflow.R
Adjusted qualification_plan.json to the latest qualification schema version
Upgraded used models to the latest versions
Upgraded used observed data to the latest version
Upgraded used text modules to the latest version
@Yuri05 Yuri05 requested review from PavelBal and Copilot June 20, 2025 12:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the qualification workflow from Matlab to R and updates inputs to match the new qualification schema. Key changes include:

  • Implementation of a new R-based workflow script (Qualification/workflow.R) replacing the Matlab version.
  • Updates to qualification_plan.json to use the new v3.3 schema including new keys and model release URLs.
  • Removal of legacy GitHub workflow files and addition of updated workflows for input file validation, markdown link checking, and model release verification.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Qualification/workflow.R New R script implementation for running the qualification workflow.
Qualification/Workflow.m Removal of the legacy Matlab workflow script.
Qualification/Input/qualification_plan.json Updated schema version, new project/model release URLs, and key renames.
Qualification/Input/Content/Qualification_DDI_network_description.md Updated model release version numbers in the content.
.github/workflows/XRefCheck.yml Removal of outdated workflow.
.github/workflows/SpellChecker.yml Removal of outdated workflow.
.github/workflows/MarkdownLinksCheck.yml Removal of outdated workflow.
.github/workflows/Check_Links_In_Report.yml New workflow to check report links and cross-references.
.github/workflows/Check_Input_Files.yml New workflow for checking input file validity.
.github/workflows/CheckUsingLatestRelease.yml New workflow to check for the latest model releases.
.github/workflows/CheckForLatestModelReleasesInQualificationPlan.yml New workflow script to verify that projects are at their latest releases.

@Yuri05
Copy link
Member Author

Yuri05 commented Jun 20, 2025

@PavelBal
Check Latest Model Releases in a Qualification Plan check fails because Fluvoxamine model uses the "alternative version" of the model, which is not the latest release

{
"Id": "Fluvoxamine",
"Path": "https://raw.githubusercontent.com/Open-Systems-Pharmacology/Fluvoxamine-Model/alt_v1.0/Fluvoxamine-Model.json"
},

grafik

@Yuri05 Yuri05 merged commit 3b3ade3 into Open-Systems-Pharmacology:main Jul 3, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants