update codecov action to latest #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yuri05 for review |
Yuri05
reviewed
Jul 24, 2024
| @@ -35,7 +35,7 @@ jobs: | |||
| covr::to_cobertura(cov) | |||
| shell: Rscript {0} | |||
|
|
|||
| - uses: codecov/codecov-action@v4 | |||
| - uses: codecov/codecov-action@v4.5 | |||
| with: | |||
| fail_ci_if_error: ${{ github.event_name != 'pull_request' && true || false }} | |||
There was a problem hiding this comment.
Why do we need the part && true || false ? Isn't it the same as just github.event_name != 'pull_request' ?
There was a problem hiding this comment.
I don't know, this is the default in r-lib actions https://github.com/r-lib/actions/tree/v2-branch/examples#test-coverage-workflow
There was a problem hiding this comment.
ok, after some reading: it seems that boolean input arguments of composite workflows are defined in the GH actions in a weird way (actions/runner#2238). So let's keep it AS IS
Yuri05
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.