Fix test coverage #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Felixmil
commented
Jul 25, 2024
•
Felixmil
commented
- Now explicitely pass codecov token instead of inheriting (inherit has limitations)
- Make sure version tag is always pushed
Yuri05
reviewed
Jul 25, 2024
| @@ -35,7 +38,7 @@ jobs: | |||
| covr::to_cobertura(cov) | |||
| shell: Rscript {0} | |||
|
|
|||
| - uses: codecov/codecov-action@v4.5 | |||
| - uses: codecov/codecov-action@v4 | |||
There was a problem hiding this comment.
For some reason it does not work.
+ looking for v4 will already get latest v4.x (it is a sliding tag)
+ It wasn't the issue
There was a problem hiding this comment.
Probably because the version is v4.5.0
But yes, v4 will get the latest 4, so all good
Yuri05
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.