feat: add urllib3 v2 as network backend #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds urllib3 as dependency and truststore as an optional dependency
- Automatically includes urllib3 v2 in all targets
- We're targeting latest Debian which is currently Bookworm and it defaults to 3.11
R1kaB3rN
force-pushed
the
urllib3-backend
branch
from
b0a7cfd to
e75eb28
Compare
R1kaB3rN
force-pushed
the
urllib3-backend
branch
from
5f3368b to
5d81fab
Compare
R1kaB3rN
force-pushed
the
urllib3-backend
branch
from
7b0e159 to
87a59aa
Compare
- We shouldn't crash here as it would be non-critical for users that already have an existing runtime that's intact. In this case, let the user run their game with the runtime already installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264.
Adds urllib3 version 2 as the network backend for umu-launcher to ensure more reliable installation and updates of the runtime for users. All network requests will be subject to a strict 5 second timeout to ensure users will not hang, and requests that return a 301 or similar will be auto redirected for any endpoint. When the connection suddenly drops, umu-launcher will retry the connection a total of 2 times and save the downloaded file in $XDG_CACHE_HOME/umu where it will be picked up for resumption on the next launch.
urllib2 will be a vendored dependency as, understandably, most Linux distributions do not package v2. For maintainers, python3-pip or similar will be an additional build dependency to install it. However, once HTTPX makes its async dependencies optional, we'll consider opting to use that instead and dropping urllib3. Additionally, truststore will be an optional dependency to allow the usage of the system's native CA bundle instead of certifi's for network requests.