Skip to content

Conversation

@antoinemzs
Copy link
Member

@antoinemzs antoinemzs commented Jan 29, 2026

Proposed changes

  • Prevent fetching of fields for encrypted secrets from API
  • Special case omitted secrets in instance update form
  • Enable XTM Composer in dev compose file

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@antoinemzs antoinemzs changed the base branch from master to release/current January 29, 2026 17:12
Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
@antoinemzs antoinemzs force-pushed the fix/dont_retreive_secrets_from_api branch from bcd40f6 to dc4a1f5 Compare January 29, 2026 17:12
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.16%. Comparing base (99a8275) to head (67ddd9b).

Files with missing lines Patch % Lines
.../connector_instances/ConnectorInstanceService.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #4822      +/-   ##
=====================================================
- Coverage              55.17%   55.16%   -0.01%     
- Complexity              4287     4290       +3     
=====================================================
  Files                    971      971              
  Lines                  28854    28857       +3     
  Branches                2110     2110              
=====================================================
- Hits                   15921    15920       -1     
- Misses                 11996    12000       +4     
  Partials                 937      937              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Antoine MAZEAS <antoine.mazeas@filigran.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants