openamp/virtio.h: update vdev->features and make final_features optional #610
Conversation
wyr-7
force-pushed
the
virtio_final_feature_null
branch
from
e09a641
to
412f254
Compare
wyr-7
force-pushed
the
virtio_final_feature_null
branch
from
412f254
to
f472fe6
Compare
There was a problem hiding this comment.
This is a good change, but it should be in its own pull request. It also should have a better explanation in the commit message, and a comment explaining what the function actually returns.
Suggestion for commit message:
Make rproc_virtio_negotiate_features() return the mask of features successfully negotiated.
The comment for rproc_virtio_negotiate_features () could be worded similarly.
wyr-7
force-pushed
the
virtio_final_feature_null
branch
from
f472fe6
to
1f14efb
Compare
wyr-7
changed the title
wyr-7
force-pushed
the
virtio_final_feature_null
branch
from
1f14efb
to
41dbe49
Compare
Make rproc_virtio_negotiate_features() return the mask of features successfully negotiated. Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com>
set vdev->features in virtio_negotiate_features Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com>
negotiate also can be call when final_features is NULL Signed-off-by: Yongrong Wang <wangyongrong@xiaomi.com>
wyr-7
force-pushed
the
virtio_final_feature_null
branch
from
41dbe49
to
8c2929e
Compare
Ok, done. |
add helpful judge for final_features is NULL and update vdev->features in virtio_negotiate_features