Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jan 22, 2026

based on #22771

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fix sample generation to work in tmux and make failures surface reliably.

  • Bug Fixes
    • generate-samples.sh: write output to a temp file via tee to preserve logs in tmux and CI.
    • Capture exit codes via PIPESTATUS and grep stack traces; exit 1 on errors.
    • Remove obsolete sleep warning.

Written for commit 81e4e60. Summary will update on new commits.

stephenfin and others added 7 commits January 20, 2026 13:46
The sleep itself has been commented out for a long time (commit
04fa53b from September 2023, to be specific).

Signed-off-by: Stephen Finucane <stephen@that.guru>
Commit 23dae2b reworked this script to start capturing exceptions
but the mechanism used was crude and broke output on tmux, since
`/dev/pts/0` is hardcoded to a specific pseudo-terminal but each tmux
pane gets its own pts. Rework this to use files instead.

Signed-off-by: Stephen Finucane <stephen@that.guru>
@wing328 wing328 changed the title Stephenfin generate sample fixes2 Fix output of bin/generate-samples.sh in tmux Jan 22, 2026
@wing328 wing328 marked this pull request as ready for review January 22, 2026 11:01
@wing328 wing328 merged commit cc045ab into master Jan 22, 2026
87 checks passed
@wing328 wing328 deleted the stephenfin-generate-sample-fixes2 branch January 22, 2026 11:02
@wing328 wing328 added this to the 7.20.0 milestone Jan 22, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants