Skip to content

Conversation

@saxicek
Copy link

@saxicek saxicek commented Jan 22, 2026

Updated TypeScript Angular configuration.mustache to properly handle apiKeys in query parameters by using OpenApiHttpParams instead of HttpHeaders to avoid compilation errors.

Fixes #22774

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@taxpon, @joscha


Summary by cubic

Fixes compilation errors in generated TypeScript Angular services when apiKeys are added to query params by using OpenApiHttpParams instead of HttpParams. Fixes #22774.

  • Bug Fixes
    • Import OpenApiHttpParams and update addCredentialToQuery to use it.
    • Prevents type mismatch when setting apiKeys on query params.

Written for commit 01396bb. Summary will update on new commits.

Updated TypeScript Angular `configuration.mustache` to properly handle
apiKeys in query parameters by using `OpenApiHttpParams` instead of
`HttpHeaders` to avoid compilation errors.

Fixes OpenAPITools#22774
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@saxicek
Copy link
Author

saxicek commented Jan 22, 2026

CircleCI failed on error ERROR: no healthy upstream. Can you uplease re-run it or ignore the failed results?

@wing328 wing328 closed this Jan 22, 2026
@wing328 wing328 reopened this Jan 22, 2026
@wing328
Copy link
Member

wing328 commented Jan 23, 2026

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][typescript-angular] apiKeys cause service compilation errors

2 participants