Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Feb 10, 2026

Remove coding: utf-8 from python files as that's the default already for python 3

cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Remove unnecessary "# coding: utf-8" headers from Python templates and generated clients, since UTF-8 is the default in Python 3. This cleans up files with no behavior change.

  • Refactors
    • Removed encoding headers from python/*.mustache, including setup.mustache
    • Regenerated Python sample clients to reflect the change

Written for commit 7b8e544. Summary will update on new commits.

@wing328 wing328 added this to the 7.20.0 milestone Feb 10, 2026
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Feb 10, 2026
@wing328 wing328 marked this pull request as ready for review February 10, 2026 08:04
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 73 files

Copy link
Contributor

@fa0311 fa0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used to question the necessity of this 😀

@wing328
Copy link
Member Author

wing328 commented Feb 10, 2026

@fa0311 yeah. It's something left over from supporting python 2 before. Thanks for the quick review.

@wing328 wing328 merged commit 7eeab03 into master Feb 10, 2026
47 checks passed
@wing328 wing328 deleted the remove-coding-utf-8 branch February 10, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Python Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants