Skip to content

Commit

Permalink
Added Script to check Lua Abilites and Items (#919)
Browse files Browse the repository at this point in the history
Added `.lua` to all "ScriptFile" Keys
Fixed AbilitySpecial Numbering of Charger's Charge and Shroud 1
Fixed Item Turret and Spell Totem not not crash parseKV cause of an empty value
FIxed Satanic Core looking for a non existing Special Value "radius"
Removed leftover variables in trumps_fists.lua
Removed unused variable in reactive_reflex.lua
Removed leftover pull staff file
Removed not working write-version.js
  • Loading branch information
Chronophylos authored and chrisinajar committed May 28, 2017
1 parent 144cb29 commit f7193ad
Show file tree
Hide file tree
Showing 27 changed files with 248 additions and 163 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "5169" // unique ID number for this ability. Do not change this once established or it will invalidate collected stats.
"BaseClass" "ability_lua"
"ScriptFile" "abilities/oaa_call_of_the_wild_hawk"
"ScriptFile" "abilities/oaa_call_of_the_wild_hawk.lua"
"AbilityTextureName" "beastmaster_call_of_the_wild"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"MaxLevel" "6"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "5580" // unique ID number for this ability. Do not change this once established or it will invalidate collected stats.
"BaseClass" "ability_lua"
"ScriptFile" "abilities/oaa_call_of_the_wild_boar"
"ScriptFile" "abilities/oaa_call_of_the_wild_boar.lua"
"AbilityTextureName" "beastmaster_call_of_the_wild_boar"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"MaxLevel" "6"
Expand Down
8 changes: 4 additions & 4 deletions game/scripts/npc/abilities/charger/boss_charger_charge.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,22 +71,22 @@
//----------------------------------
// Glacing blow, when the charger strikes a hero indirectly and pushes them away
//----------------------------------
"09"
"10"
{
"var_type" "FIELD_FLOAT"
"glacing_damage" "75 100 150"
}
"10"
"11"
{
"var_type" "FIELD_FLOAT"
"glacing_slow" "10 30 50"
}
"11"
"12"
{
"var_type" "FIELD_FLOAT"
"glacing_duration" "1 2 3"
}
"12"
"13"
{
"var_type" "FIELD_FLOAT"
"glacing_knockback" "200 250 300"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/abilities/enigma_demonic_conversion.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "5147" // unique ID number for this ability. Do not change this once established or it will invalidate collected stats.
"BaseClass" "ability_lua"
"ScriptFile" "abilities/oaa_demonic_conversion"
"ScriptFile" "abilities/oaa_demonic_conversion.lua"
"AbilityTextureName" "enigma_demonic_conversion"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_UNIT_TARGET | DOTA_ABILITY_BEHAVIOR_DONT_RESUME_ATTACK"
"AbilityUnitTargetTeam" "DOTA_UNIT_TARGET_TEAM_BOTH"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/abilities/furion_force_of_nature.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"ID" "5247" // unique ID number for this ability. Do not change this once established or it will invalidate collected stats.
"BaseClass" "ability_lua"
"AbilityTextureName" "furion_force_of_nature"
"ScriptFile" "abilities/oaa_force_of_nature"
"ScriptFile" "abilities/oaa_force_of_nature.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_POINT | DOTA_ABILITY_BEHAVIOR_AOE"

// Stats
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "5081" // unique ID number for this ability. Do not change this once established or it will invalidate collected stats.
"BaseClass" "ability_lua"
"ScriptFile" "abilities/oaa_shadow_shaman_mass_serpent_ward"
"ScriptFile" "abilities/oaa_shadow_shaman_mass_serpent_ward.lua"
"AbilityTextureName" "shadow_shaman_mass_serpent_ward"
"AbilityType" "DOTA_ABILITY_TYPE_ULTIMATE"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_POINT"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_infinite_bottle.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"ID" "41"
"BaseClass" "item_lua"
"AbilityTextureName" "item_bottle"
"ScriptFile" "items/bottle"
"ScriptFile" "items/bottle.lua"

"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET"

Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_martyrs_mail.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"BaseClass" "item_lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"AbilityTextureName" "custom/martyrs_mail"
"ScriptFile" "items/martyrs_mail"
"ScriptFile" "items/martyrs_mail.lua"

// Stats
//-------------------------------------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_martyrs_mail_2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"BaseClass" "item_lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"AbilityTextureName" "custom/martyrs_mail_2"
"ScriptFile" "items/martyrs_mail"
"ScriptFile" "items/martyrs_mail.lua"

// Stats
//-------------------------------------------------------------------------------------------------------------
Expand Down
84 changes: 0 additions & 84 deletions game/scripts/npc/items/item_pull_staff.txt

This file was deleted.

2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_satanic_core.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3221" // unique ID
"BaseClass" "item_lua"
"ScriptFile" "items/satanic_core"
"ScriptFile" "items/satanic_core.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"FightRecapLevel" "2"
"AbilityTextureName" "custom/satanic_core_1"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_satanic_core_2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3222" // unique ID
"BaseClass" "item_lua"
"ScriptFile" "items/satanic_core"
"ScriptFile" "items/satanic_core.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"FightRecapLevel" "2"
"AbilityTextureName" "custom/satanic_core_2"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_satanic_core_3.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3223" // unique ID
"BaseClass" "item_lua"
"ScriptFile" "items/satanic_core"
"ScriptFile" "items/satanic_core.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET"
"FightRecapLevel" "2"
"AbilityTextureName" "custom/satanic_core_3"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_shivas_cuirass.txt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3226" // unique ID number for this item. Do not change this once established or it will invalidate collected stats.
"BaseClass" "item_lua"
"ScriptFile" "items/shivas_cuirass"
"ScriptFile" "items/shivas_cuirass.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET | DOTA_ABILITY_BEHAVIOR_IGNORE_CHANNEL"
"FightRecapLevel" "1"
"AbilityTextureName" "custom/shivas_cuirass"
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_shivas_cuirass_2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3227" // unique ID number for this item. Do not change this once established or it will invalidate collected stats.
"BaseClass" "item_lua"
"ScriptFile" "items/shivas_cuirass"
"ScriptFile" "items/shivas_cuirass.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_NO_TARGET | DOTA_ABILITY_BEHAVIOR_IGNORE_CHANNEL"
"FightRecapLevel" "1"
"AbilityTextureName" "custom/shivas_cuirass_2"
Expand Down
9 changes: 4 additions & 5 deletions game/scripts/npc/items/item_shroud.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3234" // unique ID number for this item. Do not change this once established or it will invalidate collected stats.
"BaseClass" "item_lua"
"ScriptFile" "items/shroud"
"ScriptFile" "items/shroud.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_UNIT_TARGET | DOTA_ABILITY_BEHAVIOR_IGNORE_CHANNEL | DOTA_ABILITY_BEHAVIOR_DONT_RESUME_MOVEMENT"
"AbilityUnitTargetTeam" "DOTA_UNIT_TARGET_TEAM_FRIENDLY"
"AbilityUnitTargetType" "DOTA_UNIT_TARGET_HERO"
Expand Down Expand Up @@ -80,17 +80,17 @@
"bonus_attack_speed" "25 28"
}
// Glimmer Cape Parameters
"02"
"03"
{
"var_type" "FIELD_INTEGER"
"bonus_magical_armor" "15 20"
}
"03"
"04"
{
"var_type" "FIELD_FLOAT"
"duration" "4.0"
}
"04"
"05"
{
"var_type" "FIELD_INTEGER"
"extra_spell_damage_percent" "0" // Zero Spell Amp from Ghost Scepter
Expand All @@ -112,5 +112,4 @@
}
}
}

}
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_shroud_2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
//-------------------------------------------------------------------------------------------------------------
"ID" "3235" // unique ID number for this item. Do not change this once established or it will invalidate collected stats.
"BaseClass" "item_lua"
"ScriptFile" "items/shroud"
"ScriptFile" "items/shroud.lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_IMMEDIATE | DOTA_ABILITY_BEHAVIOR_UNIT_TARGET | DOTA_ABILITY_BEHAVIOR_IGNORE_CHANNEL | DOTA_ABILITY_BEHAVIOR_DONT_RESUME_MOVEMENT"
"AbilityUnitTargetTeam" "DOTA_UNIT_TARGET_TEAM_FRIENDLY"
"AbilityUnitTargetType" "DOTA_UNIT_TARGET_HERO"
Expand Down
4 changes: 3 additions & 1 deletion game/scripts/npc/items/item_spell_totem.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@
"modifier_item_spell_totem_summon"
{
"OnSpellStart"
{}
{
"SpawnUnit" ""
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_trumps_fists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"BaseClass" "item_lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_PASSIVE"
"AbilityTextureName" "custom/trumps_fists"
"ScriptFile" "items/trumps_fists"
"ScriptFile" "items/trumps_fists.lua"

// Stats
//-------------------------------------------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion game/scripts/npc/items/item_trumps_fists_2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"BaseClass" "item_lua"
"AbilityBehavior" "DOTA_ABILITY_BEHAVIOR_PASSIVE"
"AbilityTextureName" "custom/trumps_fists_2"
"ScriptFile" "items/trumps_fists"
"ScriptFile" "items/trumps_fists.lua"
// Stats
//-------------------------------------------------------------------------------------------------------------
"MaxUpgradeLevel" "2"
Expand Down
4 changes: 3 additions & 1 deletion game/scripts/npc/items/item_turret.txt
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@
"modifier_item_turret_summon"
{
"OnSpellStart"
{}
{
"SpawnUnit" ""
}
}
}

Expand Down
1 change: 0 additions & 1 deletion game/scripts/vscripts/items/reflex/reactive_reflect.lua
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ function item_reactive_3a:OnSpellStart()
return false
end

local maxCharges = self:GetSpecialValueFor( "max_charges" )
local caster = self:GetCaster()
local duration = self:GetSpecialValueFor( "duration" )

Expand Down
Loading

0 comments on commit f7193ad

Please sign in to comment.