Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pika may compile fail in some centos platform #2865

Merged

Conversation

cheniujh
Copy link
Collaborator

@cheniujh cheniujh commented Aug 14, 2024

fix: pika may compile fail in some centos platform

Summary by CodeRabbit

  • New Features
    • Enhanced compatibility with CentOS alongside Rocky for library path configurations, improving build flexibility across operating systems.

Copy link

coderabbitai bot commented Aug 14, 2024

Walkthrough

The changes in the CMakeLists.txt file enhance compatibility for library paths by expanding conditional checks to include both Rocky and CentOS operating systems. This adjustment ensures that the build configuration correctly identifies and links necessary libraries for a broader range of environments, thereby increasing flexibility and robustness without altering the overall control flow.

Changes

Files Change Summary
CMakeLists.txt Expanded conditions for library paths to include CentOS alongside Rocky, affecting GTest, Glog, Snappy, Zstd, Fmt, LZ4, and RocksDB.

Poem

In the land of code where rabbits hop,
We’ve made some changes, oh what a crop!
With Rocky and CentOS now in our sights,
Libraries link with great delight!
So let’s celebrate with a joyful cheer,
For flexible builds, we hold dear! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Aug 14, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3f52ad0 and 5298a16.

Files selected for processing (1)
  • CMakeLists.txt (7 hunks)
Additional comments not posted (6)
CMakeLists.txt (6)

Line range hint 163-169: LGTM: Broadened OS compatibility.

The conditional check now includes both Rocky and CentOS, which enhances compatibility. This change aligns with the PR objectives.


Line range hint 286-290: LGTM: Consistent library path setting.

Including both Rocky and CentOS in the conditional check ensures the correct GLOG library path is set, consistent with other changes.


Line range hint 321-325: LGTM: SNAPPY library path adjustment.

The inclusion of both Rocky and CentOS ensures the SNAPPY library path is correctly set, enhancing compatibility.


Line range hint 359-363: LGTM: ZSTD library path consistency.

The conditional check now includes both Rocky and CentOS, ensuring the correct ZSTD library path is set.


Line range hint 398-402: LGTM: FMT library path adjustment.

Including both Rocky and CentOS in the conditional check ensures the correct FMT library path is set, enhancing compatibility.


Line range hint 436-440: LGTM: LZ4 library path consistency.

The conditional check now includes both Rocky and CentOS, ensuring the correct LZ4 library path is set.

@AlexStocks AlexStocks merged commit cc3fe0f into OpenAtomFoundation:unstable Aug 14, 2024
13 checks passed
cheniujh added a commit that referenced this pull request Aug 15, 2024
cheniujh added a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.5 4.0.1 ☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants