-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pika may compile fail in some centos platform #2865
fix: pika may compile fail in some centos platform #2865
Conversation
WalkthroughThe changes in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CMakeLists.txt (7 hunks)
Additional comments not posted (6)
CMakeLists.txt (6)
Line range hint
163-169
: LGTM: Broadened OS compatibility.The conditional check now includes both Rocky and CentOS, which enhances compatibility. This change aligns with the PR objectives.
Line range hint
286-290
: LGTM: Consistent library path setting.Including both Rocky and CentOS in the conditional check ensures the correct GLOG library path is set, consistent with other changes.
Line range hint
321-325
: LGTM: SNAPPY library path adjustment.The inclusion of both Rocky and CentOS ensures the SNAPPY library path is correctly set, enhancing compatibility.
Line range hint
359-363
: LGTM: ZSTD library path consistency.The conditional check now includes both Rocky and CentOS, ensuring the correct ZSTD library path is set.
Line range hint
398-402
: LGTM: FMT library path adjustment.Including both Rocky and CentOS in the conditional check ensures the correct FMT library path is set, enhancing compatibility.
Line range hint
436-440
: LGTM: LZ4 library path consistency.The conditional check now includes both Rocky and CentOS, ensuring the correct LZ4 library path is set.
fix: pika may compile fail in some centos platform
Summary by CodeRabbit