fix: use Lead Style from MP tick import instead of Style #1259
Conversation
|
Should we also coerce imported fields from MP into the set of possible values defined in OpenBeta/openbeta-graphql#444? That could also be a separate PR, but it is necessary in order to make the change to allowable types |
glassbead0
force-pushed
the
import_mp_attempt_style_correctly_424
branch
from
8b3c22d to
9826bc3
Compare
|
Update: I allowed null for both |
glassbead0
force-pushed
the
import_mp_attempt_style_correctly_424
branch
from
9826bc3 to
010ed46
Compare
|
Testing the PR locally (connecting to staging api, not local api server) I'm getting 
|
|
can you also increase the timeout to 180000 (3 mins)? |
glassbead0
force-pushed
the
import_mp_attempt_style_correctly_424
branch
from
010ed46 to
da987e5
Compare
|
The issue of null vs 'N/A'...etc should be coordinated among these 3 PRs:
Probably best discussed with mouth words if we meet this week. |
glassbead0
force-pushed
the
import_mp_attempt_style_correctly_424
branch
from
da987e5 to
7d12e43
Compare
* convert 'Fell/Hung' to 'Attempt' since thats what OB uses * add .tool-versions to gitignore for anyone using asdf * somewhat complicated logic for other edge cases * references md document in openbeta-graphql for ease of understanding the logic
glassbead0
force-pushed
the
import_mp_attempt_style_correctly_424
branch
from
7d12e43 to
4ccfb95
Compare
name: Pull request
about: Create a pull request
title: 'correctly import attemptStyle from MP tick import'
labels: ''
assignees: ''
What type of PR is this?(check all applicable)
Description
When importing ticks from Mountain Project, the
attemptStylefield was being populated with theStylefield from MP. It should use theLead Stylefield instead.Related Issues
Issue #
The issue was created in openbeta-graphql, but the code is in open-tacos.
OpenBeta/openbeta-graphql#424
What this PR achieves
When converting a MPTick to a Tick object, set
attemptStyleon Tick to be the value fromLead Styleon MPTick (if present).Notes
I don't see an obvious way to write tests for this. everything in tests/ticks.ts mocks out Tick objects after the conversion from MPTick has already happened, so a new test would probably have to be more of an end-to-end tests.
Below screenshot shows imported ticks locally, and the attemptType fields being populated with correct values.
