Skip to content

Commit

Permalink
remove submodules, remove webview_cef depend from macos and windows
Browse files Browse the repository at this point in the history
  • Loading branch information
EricApostal committed Dec 19, 2024
1 parent c42794f commit 8b42415
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 30 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,17 +98,17 @@ jobs:
& "C:\Program Files (x86)\Microsoft Visual Studio\Installer\InstallCleanup.exe"
shell: pwsh

- name: Install Visual Studio 2022 Enterprise
run: |
Invoke-WebRequest -Uri https://aka.ms/vs/17/release.ltsc.17.10/vs_enterprise.exe -OutFile vs_enterprise.exe
$process = Start-Process -FilePath '.\vs_enterprise.exe' -ArgumentList "--add", "Microsoft.VisualStudio.Workload.Azure", "--quiet", "--norestart", "--wait", "--includeRecommended" -Wait -PassThru
Write-Output $process.ExitCode
$process = Start-Process -FilePath '.\vs_enterprise.exe' -ArgumentList "--add", "Microsoft.VisualStudio.Workload.NativeDesktop", "--quiet", "--norestart", "--wait", "--includeRecommended" -Wait -PassThru
Write-Output $process.ExitCode
shell: pwsh

- name: Set up Visual Studio
uses: microsoft/setup-msbuild@v1.1
# - name: Install Visual Studio 2022 Enterprise
# run: |
# Invoke-WebRequest -Uri https://aka.ms/vs/17/release.ltsc.17.10/vs_enterprise.exe -OutFile vs_enterprise.exe
# $process = Start-Process -FilePath '.\vs_enterprise.exe' -ArgumentList "--add", "Microsoft.VisualStudio.Workload.Azure", "--quiet", "--norestart", "--wait", "--includeRecommended" -Wait -PassThru
# Write-Output $process.ExitCode
# $process = Start-Process -FilePath '.\vs_enterprise.exe' -ArgumentList "--add", "Microsoft.VisualStudio.Workload.NativeDesktop", "--quiet", "--norestart", "--wait", "--includeRecommended" -Wait -PassThru
# Write-Output $process.ExitCode
# shell: pwsh

# - name: Set up Visual Studio
# uses: microsoft/setup-msbuild@v1.1

- name: Set up Flutter
uses: subosito/flutter-action@v2
Expand Down
12 changes: 0 additions & 12 deletions .gitmodules

This file was deleted.

7 changes: 3 additions & 4 deletions bonfire/pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1930,10 +1930,9 @@ packages:
webview_cef:
dependency: transitive
description:
name: webview_cef
sha256: "2e660bf593dc1168beb7b765dd477a703e0b29968669f017e178c2c716f6437f"
url: "https://pub.dev"
source: hosted
path: "../webview_cef"
relative: true
source: path
version: "0.2.2"
webview_flutter:
dependency: transitive
Expand Down
3 changes: 0 additions & 3 deletions bonfire/windows/runner/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ auto bdw = bitsdojo_window_configure(BDW_CUSTOM_FRAME | BDW_HIDE_ON_STARTUP);
int APIENTRY wWinMain(_In_ HINSTANCE instance, _In_opt_ HINSTANCE prev,
_In_ wchar_t *command_line, _In_ int show_command)
{
initCEFProcesses();
// Attach to console when present (e.g., 'flutter run') or create a
// new console when running with a debugger.
if (!::AttachConsole(ATTACH_PARENT_PROCESS) && ::IsDebuggerPresent())
Expand Down Expand Up @@ -45,8 +44,6 @@ int APIENTRY wWinMain(_In_ HINSTANCE instance, _In_opt_ HINSTANCE prev,
{
::TranslateMessage(&msg);
::DispatchMessage(&msg);

handleWndProcForCEF(msg.hwnd, msg.message, msg.wParam, msg.lParam);
}

::CoUninitialize();
Expand Down
1 change: 1 addition & 0 deletions webview_cef
Submodule webview_cef added at ebd531

0 comments on commit 8b42415

Please sign in to comment.