Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: /service/all -> /service/status/all #45

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

synackd
Copy link
Collaborator

@synackd synackd commented Aug 8, 2024

Introduces one of multiple fixes for #20.

The Swagger file documents the endpoint for getting a status summary as /service/status/all. #43 implemented this as /service/all, so this PR corrects the endpoint to the documented one.

The latter endpoint is documented in Swagger, so the actual endpoint
should match.
@synackd synackd self-assigned this Aug 8, 2024
Copy link
Contributor

@davidallendj davidallendj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@synackd synackd merged commit b490a0a into OpenCHAMI:main Aug 8, 2024
1 check passed
@synackd synackd deleted the fix-status-all-ep branch August 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants