Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update body-parser to 1.20.3 for transitive dependencies #8331

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Sep 12, 2024

Proposed changes

  • Fix body-parser transitive dependency to 1.20.3

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 12, 2024
@aHenryJard aHenryJard added the dependencies use for pull requests that update a dependency file label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (b7e8a1a) to head (412d89c).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8331      +/-   ##
==========================================
+ Coverage   66.13%   66.14%   +0.01%     
==========================================
  Files         597      597              
  Lines       60375    60375              
  Branches     6189     6193       +4     
==========================================
+ Hits        39930    39937       +7     
+ Misses      20445    20438       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard marked this pull request as ready for review September 13, 2024 07:46
@SouadHadjiat
Copy link
Member

I still see in yarn.lock:

"express@npm:^4.17.1":
  version: 4.19.2
  resolution: "express@npm:4.19.2"
  dependencies:
    accepts: "npm:~1.3.8"
    array-flatten: "npm:1.1.1"
    body-parser: "npm:1.20.2"

I'm not sure it's an issue to see body-parser: "npm:1.20.2" here.

@aHenryJard aHenryJard force-pushed the dependabot/body-parser-1.20.3 branch 3 times, most recently from 8c69ccc to fb1c70d Compare September 17, 2024 14:23
@aHenryJard aHenryJard force-pushed the dependabot/body-parser-1.20.3 branch from fb1c70d to 412d89c Compare September 18, 2024 16:17
@aHenryJard aHenryJard merged commit a657887 into master Sep 19, 2024
6 checks passed
@aHenryJard aHenryJard deleted the dependabot/body-parser-1.20.3 branch October 28, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies use for pull requests that update a dependency file filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants