Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/backend] Specify arch and platform when creating injects for OpenBAS (#8820) #9250

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

savacano28
Copy link

@savacano28 savacano28 commented Dec 5, 2024

Proposed changes

  • Refactor form StixCoreObjectSimulationResult to add platforms and arch, and some behavior related to AI option.
  • Add placeholder for ttps not covered from obas.

Docs

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Dec 5, 2024
@savacano28 savacano28 self-assigned this Dec 5, 2024
@savacano28 savacano28 changed the title [frontend/backend] wip [frontend/backend] Specify arch and platform when creating injects for OpenBAS (#8820) Dec 5, 2024
@savacano28 savacano28 force-pushed the issue/8820 branch 4 times, most recently from 3f41956 to 7ee2dc3 Compare December 10, 2024 14:39
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 4.56026% with 293 lines in your changes missing coverage. Please review.

Project coverage is 64.49%. Comparing base (9da1ce0) to head (659dee5).
Report is 5 commits behind head on release/6.5.0.

Files with missing lines Patch % Lines
...form/opencti-graphql/src/modules/xtm/xtm-domain.js 4.97% 172 Missing ⚠️
...i-graphql/src/modules/xtm/deprecated/xtm-domain.js 0.00% 66 Missing ⚠️
...-platform/opencti-graphql/src/database/xtm-obas.ts 2.56% 38 Missing ⚠️
...graphql/src/modules/xtm/deprecated/xtm-resolver.ts 0.00% 10 Missing ⚠️
...aphql/src/modules/xtm/deprecated/xtm-deprecated.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.5.0    #9250      +/-   ##
=================================================
- Coverage          64.57%   64.49%   -0.08%     
=================================================
  Files                641      644       +3     
  Lines              61918    62179     +261     
  Branches            6879     6979     +100     
=================================================
+ Hits               39984    40105     +121     
- Misses             21934    22074     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@savacano28 savacano28 marked this pull request as ready for review December 10, 2024 16:42
@savacano28 savacano28 marked this pull request as draft December 11, 2024 10:57
@savacano28 savacano28 requested a review from Archidoit December 12, 2024 11:52
@savacano28 savacano28 marked this pull request as ready for review December 12, 2024 11:52
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When OBAS has error the success message is displayed in UI ("Le scénario a été correctement généré dans votre plateforme OpenBAS.") would be better to say that something has not worked IMO. Maybe better to throw exception.

@Archidoit
Copy link
Member

I pushed the modifications to remove the useLazyLoadQuery

@Archidoit
Copy link
Member

Archidoit commented Jan 21, 2025

Maybe see if we can activate EE from there
image

(here EE chips are disabled)

@Archidoit
Copy link
Member

I do a simulation of type 'simulated emails' on a report that contains 1 attack pattern.
image

I have a message of success.
image

But when I click on Access scenaio, there is nothing in 'injects' :
image

@savacano28 savacano28 requested a review from Archidoit January 21, 2025 15:01
Archidoit
Archidoit previously approved these changes Jan 21, 2025
@savacano28 savacano28 changed the base branch from master to release/6.5.0 January 21, 2025 16:23
@savacano28 savacano28 requested a review from Archidoit January 21, 2025 17:43
@savacano28 savacano28 merged commit d6ec70b into release/6.5.0 Jan 22, 2025
5 checks passed
@savacano28 savacano28 deleted the issue/8820 branch January 22, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
4 participants