-
Notifications
You must be signed in to change notification settings - Fork 974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] Specify arch and platform when creating injects for OpenBAS (#8820) #9250
Conversation
3f41956
to
7ee2dc3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/6.5.0 #9250 +/- ##
=================================================
- Coverage 64.57% 64.49% -0.08%
=================================================
Files 641 644 +3
Lines 61918 62179 +261
Branches 6879 6979 +100
=================================================
+ Hits 39984 40105 +121
- Misses 21934 22074 +140 ☔ View full report in Codecov by Sentry. |
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
1761075
to
f4abc2e
Compare
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
10fafec
to
d8dcb3a
Compare
6d8119d
to
14d43ce
Compare
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
dae6e27
to
868e779
Compare
b414944
to
c7f4cb7
Compare
ccf34f2
to
09f4393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When OBAS has error the success message is displayed in UI ("Le scénario a été correctement généré dans votre plateforme OpenBAS.") would be better to say that something has not worked IMO. Maybe better to throw exception.
b321e1c
to
3095e17
Compare
...cti-front/src/private/components/common/stix_core_objects/StixCoreObjectSimulationResult.jsx
Outdated
Show resolved
Hide resolved
I pushed the modifications to remove the useLazyLoadQuery |
7dfe2d5
to
a91aa60
Compare
Proposed changes
Docs
Notion with uses cases to test: https://www.notion.so/filigran/Test-OCTI-OBAS-1548fce17f2a8060adf6e3e99740452b
Notion with Api update: https://www.notion.so/filigran/Integration-OCTI-OBAS-1598fce17f2a800a9cddea83b6e6f39f
PR Doc OBAS: [docs] Update doc for feature generating scenario octi - obas OpenBAS-Platform/docs#72
PR Doc deprecated notice: [docs] Add deprecated notice about changes on GenerationScenario OpenCTI OpenBAS docs#239
Related issues
Checklist
Further comments