Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] keep increasing back pressure delay if queue size keeps increasing (#9358) #9555

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Jan 10, 2025

Proposed changes

  • before, we only increased connection delay once in manageBackPressure. We now keep increasing the delay if the first delay increase wasn't enough to be able to reduce current queue size

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.13%. Comparing base (7180d27) to head (db97bae).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...latform/opencti-graphql/src/manager/syncManager.js 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9555      +/-   ##
==========================================
- Coverage   65.13%   65.13%   -0.01%     
==========================================
  Files         630      630              
  Lines       60147    60150       +3     
  Branches     6703     6705       +2     
==========================================
- Hits        39179    39176       -3     
- Misses      20968    20974       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richard-julien richard-julien force-pushed the master branch 5 times, most recently from b414944 to c7f4cb7 Compare January 13, 2025 09:27
@SouadHadjiat SouadHadjiat self-requested a review January 13, 2025 10:22
@JeremyCloarec JeremyCloarec merged commit 008cc21 into master Jan 13, 2025
9 checks passed
@JeremyCloarec JeremyCloarec deleted the issue/9538 branch January 13, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when ingesting an opencti stream configured with an empty starting synchronization date
2 participants