Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove html escapes for generic23 #113

Merged

Conversation

laugehoyer
Copy link
Contributor

It seems like a mistake to html-escape these fields.

E.g.

{
  house: "St. Judes & St. Pauls C of E (Va) Primary School",
  house_number: "10",
  road: "Kingsbury Road".
  city: "London",
  postcode: "N1 4AZ",
}

becomes

St. Judes & St. Pauls C of E (Va) Primary School
10 Kingsbury Road
London
N1 4AZ

@freyfogle
Copy link
Member

Hi,

thanks for contributing.

You are right that htmlizing the & is unexpected and problematic. Thanks for making us aware.

I am not sure your change is the best solution, why would we do it only for generic23 and only for those fields?
I think this may be an issue that should be deal with by the parsers. Let me mull for a bit (not least as am currently on holiday).

@freyfogle freyfogle merged commit 1f7d0a2 into OpenCageData:master Aug 22, 2024
1 check passed
@laugehoyer
Copy link
Contributor Author

For generic23, it seems like this was an oversight introduced back in 75135e3.

Otherwise the same thing can be seen in hamlet for BR and quarter for the fallback template of TC.

@freyfogle
Copy link
Member

yes, just human error. Very wel spotted. I just checked in a fix for BR and TC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants